Opened 6 years ago

Closed 6 years ago

#57593 closed defect (fixed)

faust-devel: cmake: command not found

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: agraef (Albert Graef)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: faust-devel

Description

faust-devel fails to build with:

/bin/sh: cmake: command not found

It's missing a dependency on cmake. But it looks like we're running make, which is running cmake. Is this indirection necessary? Could we run cmake directly? MacPorts has the cmake 1.1 portgroup which is designed to run cmake with the options we generally want to use. Could we switch the port over to that?

I didn't check if the other faust-related ports need something similar.

Change History (5)

comment:1 Changed 6 years ago by agraef (Albert Graef)

It's missing a dependency on cmake.

Yes, sorry I missed that. Will fix asap.

But it looks like we're running make, which is running cmake. Is this indirection necessary?

Yes, Faust's build system has recently been reworked. But the main Makefile is still the entry point.

Could we run cmake directly?

It's probably possible, but very complicated and it would also be a maintenance nightmare, because bypassing the main Makefile we basically have to replicate everything in there, and that file still keeps changing.

comment:3 in reply to:  1 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to agraef:

Could we run cmake directly?

It's probably possible, but very complicated and it would also be a maintenance nightmare, because bypassing the main Makefile we basically have to replicate everything in there, and that file still keeps changing.

Yes, I see now, it's a very large Makefile. I agree we don't want to reimplement that.

On the other hand, there is a lot of stuff in the cmake 1.1 portgroup that, by not using it, this port may not be doing. For example, the cmake portgroup arranges for silent rules to be disabled, so that we can see the exact compile commands being issued; this port isn't doing that, so the rules are silent, so I can't see the compile lines, so I don't know if they include everything we want them to include.

comment:4 Changed 6 years ago by agraef (Albert Graef)

For example, the cmake portgroup arranges for silent rules to be disabled, so that we can see the exact compile commands being issued; this port isn't doing that, so the rules are silent, so I can't see the compile lines, so I don't know if they include everything we want them to include.

That's easy, we just need to add VERBOSE=1 to the make options.

comment:5 Changed 6 years ago by agraef (Albert Graef)

Resolution: fixed
Status: assignedclosed

In bc47bc34ef0a6992fa4ec787157eb49e344927e6/macports-ports (master):

faust-devel: add missing cmake dependency

Closes: #57593

Note: See TracTickets for help on using tickets.