BUG: libbonoboui 2.10.1_0 build fails on Panther/GCC 3.3 (libwnck, libgnomeui too)

[yaseppochi (Stephen J. Turnbull)]

Although the configure script checks for and detects the X11 libraries and headers, -I/usr/X11R6/include somehow doesn't get into CFLAGS or CPPFLAGS (although libtool does get -L/usr/X11R6/lib).

I hacked the Portfile to add -I/usr/X11R6/include to CFLAGS in configure.env, and completed the install.

[yaseppochi (Stephen J. Turnbull)]

libwnck has the same problem.

It looks like libgnomeui has the same problem. I've already edited the Portfile, so I haven't seen a build failure, but -I/usr/X11R6/include appears only once, at the end of the compile command, as it does in libbonoboui and libwnck builds.

[markd@…]

(In reply to comment #0)

Although the configure script checks for and detects the X11 libraries and headers, -I/usr/X11R6/include somehow doesn't get into CFLAGS or CPPFLAGS (although libtool does get -L/usr/X11R6/lib).

I hacked the Portfile to add -I/usr/X11R6/include to CFLAGS in configure.env, and completed the install.

libwnck has the same problem.

I have no problems installing libgnomeui, libbonoboui, and libwnck on 10.4.5. I use Apple's X11. Are you using Apple's or XFree86 from DP?

[yaseppochi (Stephen J. Turnbull)]

(In reply to comment #2)

(In reply to comment #0)

Although the configure script checks for and detects the X11 libraries and headers, -I/usr/X11R6/include somehow doesn't get into CFLAGS or CPPFLAGS (although libtool does get -L/usr/X11R6/lib).

I have no problems installing libgnomeui, libbonoboui, and libwnck on 10.4.5. I use Apple's X11. Are you using Apple's or XFree86 from DP?

X.org from DarwinPorts.

I suspect this is not an X problem, FWIW. This occurred at the same time that the world broke due to a rash of ports doing stuff that only works on Tiger.

Very circumstantial, so I'll look into anything you suggest, of course, but please don't rule out the huge changes to GCC and other parts of the environment with the upgrade to Tiger.

[markd@…]

I can now install the latest (2.14.0) versions of libbonoboui. libgnome, and libbonobo on 10.3. I also installed libwnk 2.12.3 and libgnomeui 2.12.0 with no problems. Our gnome wizard Randall has made a lot of updates. Please try again and see if the updates fixed the problem for you.

[yaseppochi (Stephen J. Turnbull)]

(In reply to comment #4)

I can now install the latest (2.14.0) versions of libbonoboui. libgnome, and libbonobo on 10.3. I also installed libwnk 2.12.3 and libgnomeui 2.12.0 with no problems. Our gnome wizard Randall has made a lot of updates. Please try again and see if the updates fixed the problem for you.

No. libwnck still shows the same problem, and libgnomeui doesn't even get that far, it seems. The build, which used to work with my patch now chokes with:

make all-recursive Making all in pixmaps rm -f gnome-stock-pixbufs.h var=echo "stock_attach.png stock_book_blue.png stock_book_green.png stock_book_open.png stock_book_red.png stock_book_yellow.png stock_line_in.png stock_mail.png stock_mail_compose.png stock_mail_forward.png stock_mail_receive.png stock_mail_reply.png stock_mail_send.png stock_menu_about.png stock_menu_blank.png stock_scores.png stock_mic.png stock_multiple_file.png stock_not.png stock_table_borders.png stock_table_fill.png stock_text_bulleted_list.png stock_text_indent.png stock_text_numbered_list.png stock_text_unindent.png stock_timer.png stock_timer_stopped.png stock_trash.png stock_trash_full.png stock_volume.png stock_midi.png stock_authentication.png" | sed -e 's,stock_\([^\.]*\)\.png,stock_\1 ./stock_\1.png,g' ; \

/opt/local/bin/gdk-pixbuf-csource --raw --build-list $var > pixbufs-tmp && \ cat ./copyright.txt pixbufs-tmp > gnome-stock-pixbufs.h

failed to load "./stock_attach.png": Couldn't recognize the image file format for file './stock_attach.png' make[4]: * [gnome-stock-pixbufs.h] Error 1 make[3]: * [all-recursive] Error 1 make[2]: * [all] Error 2 make[1]: * [all-recursive] Error 1 make: * [all] Error 2

Error: Unable to upgrade port: 1

[rhwood@…]

Please attach the file /opt/local/etc/gtk-2.0/gdk-pixbuf.loaders

This will at least tell us if one of the file-type (png, jpeg, gif, svg, etc...) handlers are broken.

[yaseppochi (Stephen J. Turnbull)]

I still don't understand why configure looks for X11 includes in /usr/X11R6/include, but then fails to add that to the include path. I guess that's upstream breakage. However,

ln -s /usr/X11R6/include/X11 /usr/include/X11

works for me. As far as I am concerned, this bug can be closed.

In general, this seems harmless, and I wouldn't be surprised if there isn't all kinds of X software that depends on it. Maybe the maintainers of the dp packages should check to see if they have this link, and if it seems like most do, conclude that you should require it. (Although I'm currently using dp's xorg package, I have at one time and another built X from XFree86 or X.org CVS and install it in /usr/X11R6, so there's no reason to suppose my /usr/X11R6 or /usr/include looks anything like sanity.)

Maybe port itself could get a lint action that checks for this kind of thing?