harfbuzz @2.3.0: hb-coretext.cc:254: error: ‘kCTFontURLAttribute’ was not declared in this scope

[kencu (Ken)]

Building on Leopard i386:

hb-coretext.cc: In function ‘const __CTFont* create_ct_font(CGFont*, CGFloat)’:
hb-coretext.cc:254: error: ‘kCTFontURLAttribute’ was not declared in this scope

The block is beautifully guarded in the source:

#if TARGET_OS_OSX && MAC_OS_X_VERSION_MIN_REQUIRED < 1060
      atsFont = CTFontGetPlatformFont (new_ct_font, NULL);
      status = ATSFontGetFileReference (atsFont, &fsref);
      if (status == noErr)
        new_url = CFURLCreateFromFSRef (NULL, &fsref);
#else
      new_url = (CFURLRef) CTFontCopyAttribute (new_ct_font, kCTFontURLAttribute);
#endif

but I can't find anywhere that TARGET_OS_OSX is ever set or referred to elsewhere.

Cutting that out of the source, or setting -DTARGET_OS_OSX in the cppflags of Portfile both work to fix the build.

$ port -v installed harfbuzz
The following ports are currently installed:
  harfbuzz @2.3.0_0 (active) platform='darwin 9' archs='i386' date='2019-01-14T20:42:32-0800'

[kencu (Ken)]

If you decide to cut it out of the source file, there are two spots where that macro is used.

[kencu (Ken)]

And the issue appears to be because harfbuzz switched from TARGET_OS_MAC to TARGET_OS_OSX due to collisions with IOS, and TARGET_OS_OSX is not defined on Leopard in:

/usr/include/TargetConditionals.h

[ryandesign (Ryan Carsten Schmidt)]

Right. We can work around this but it needs to be reported to the developers of harfbuzz.

[ryandesign (Ryan Carsten Schmidt)]

I think the fix that was ​originally suggested would have worked.

[kencu (Ken)]

<​https://github.com/harfbuzz/harfbuzz/issues/1540>

[ryandesign (Ryan Carsten Schmidt)]

In 49fecd209cde18cd6181b233aeb2bdfe8e32b6ec/macports-ports (master):

harfbuzz: Fix build on Mac OS X 10.5 and earlier

Closes: #57908