gnutls @3.6.5_1+doc: stray @CODE_COVERAGE_RULES@ in Makefile breaks build

[mmilenko]

The macro apparently isn't defined. I'm attaching the build log and the Makefile in question

[Schamschula (Marius Schamschula)]

I didn't run into this on my High Sierra Build machine, but also found this issue on a Mojave box.

[Schamschula (Marius Schamschula)]

I just realized, that my default build includes the +guile variant. I will look into this issue later on today.

Off to a seminar...

[Schamschula (Marius Schamschula)]

The mystery deepens:

gnutls built cleanly w/o the guile variant install on another High Sierra machine.

I also had a clean build on my virtual machine running Snow Leopard...

[Schamschula (Marius Schamschula)]

It looks like the following fails to be substituted for @CODE_COVERAGE_RULES@ in Mojave:

# Code coverage
#
# Optional:
#  - CODE_COVERAGE_DIRECTORY: Top-level directory for code coverage reporting.
#    Multiple directories may be specified, separated by whitespace.
#    (Default: $(top_builddir))
#  - CODE_COVERAGE_OUTPUT_FILE: Filename and path for the .info file generated
#    by lcov for code coverage. (Default:
#    $(PACKAGE_NAME)-$(PACKAGE_VERSION)-coverage.info)
#  - CODE_COVERAGE_OUTPUT_DIRECTORY: Directory for generated code coverage
#    reports to be created. (Default:
#    $(PACKAGE_NAME)-$(PACKAGE_VERSION)-coverage)
#  - CODE_COVERAGE_BRANCH_COVERAGE: Set to 1 to enforce branch coverage,
#    set to 0 to disable it and leave empty to stay with the default.
#    (Default: empty)
#  - CODE_COVERAGE_LCOV_SHOPTS_DEFAULT: Extra options shared between both lcov
#    instances. (Default: based on $CODE_COVERAGE_BRANCH_COVERAGE)
#  - CODE_COVERAGE_LCOV_SHOPTS: Extra options to shared between both lcov
#    instances. (Default: $CODE_COVERAGE_LCOV_SHOPTS_DEFAULT)
#  - CODE_COVERAGE_LCOV_OPTIONS_GCOVPATH: --gcov-tool pathtogcov
#  - CODE_COVERAGE_LCOV_OPTIONS_DEFAULT: Extra options to pass to the
#    collecting lcov instance. (Default: $CODE_COVERAGE_LCOV_OPTIONS_GCOVPATH)
#  - CODE_COVERAGE_LCOV_OPTIONS: Extra options to pass to the collecting lcov
#    instance. (Default: $CODE_COVERAGE_LCOV_OPTIONS_DEFAULT)
#  - CODE_COVERAGE_LCOV_RMOPTS_DEFAULT: Extra options to pass to the filtering
#    lcov instance. (Default: empty)
#  - CODE_COVERAGE_LCOV_RMOPTS: Extra options to pass to the filtering lcov
#    instance. (Default: $CODE_COVERAGE_LCOV_RMOPTS_DEFAULT)
#  - CODE_COVERAGE_GENHTML_OPTIONS_DEFAULT: Extra options to pass to the
#    genhtml instance. (Default: based on $CODE_COVERAGE_BRANCH_COVERAGE)
#  - CODE_COVERAGE_GENHTML_OPTIONS: Extra options to pass to the genhtml
#    instance. (Default: $CODE_COVERAGE_GENHTML_OPTIONS_DEFAULT)
#  - CODE_COVERAGE_IGNORE_PATTERN: Extra glob pattern of files to ignore
#
# The generated report will be titled using the $(PACKAGE_NAME) and
# $(PACKAGE_VERSION). In order to add the current git hash to the title,
# use the git-version-gen script, available online.

[mmilenko]

Thanks for looking at this. I'm encountering this issue on High Sierra 10.13.6

[Schamschula (Marius Schamschula)]

In High Sierra I get

Executing:  cd "/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_devel_gnutls/gnutls/work/gnutls-3.6.6" && autoreconf -fvi 
autoreconf: Entering directory `.'
autoreconf: running: /opt/local/bin/autopoint --force
Copying file m4/glibc2.m4
Copying file m4/glibc21.m4
Copying file m4/intdiv0.m4
Copying file m4/intl.m4
Copying file m4/intldir.m4
Copying file m4/intmax.m4
Copying file m4/printf-posix.m4
Copying file m4/uintmax_t.m4
Copying file m4/visibility.m4
Copying file po/Makevars.template
autoreconf: running: /opt/local/bin/aclocal --force -I m4 -I src/libopts/m4 -I src/gl/m4 -I lib/unistring/m4 --install
aclocal: overwriting 'm4/pkg.m4' with '/opt/local/share/aclocal/pkg.m4'
autoreconf: configure.ac: tracing
autoreconf: running: /opt/local/bin/glibtoolize --copy --force
glibtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
glibtoolize: copying file 'build-aux/ltmain.sh'
glibtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
glibtoolize: copying file 'm4/libtool.m4'
glibtoolize: copying file 'm4/ltoptions.m4'
glibtoolize: copying file 'm4/ltsugar.m4'
glibtoolize: copying file 'm4/ltversion.m4'
glibtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /opt/local/bin/autoconf --force
autoreconf: running: /opt/local/bin/autoheader --force
autoreconf: running: /opt/local/bin/automake --add-missing --copy --force-missing
configure.ac:41: installing 'build-aux/compile'
configure.ac:31: installing 'build-aux/missing'
doc/Makefile.am: installing 'build-aux/depcomp'

but in Mojave I see

Executing:  cd "/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_devel_gnutls/gnutls/work/gnutls-3.6.6" && autoreconf -fvi 
autoreconf: Entering directory `.'
autoreconf: running: /opt/local/bin/autopoint --force
Copying file m4/glibc2.m4
Copying file m4/glibc21.m4
Copying file m4/intdiv0.m4
Copying file m4/intl.m4
Copying file m4/intldir.m4
Copying file m4/intmax.m4
Copying file m4/printf-posix.m4
Copying file m4/uintmax_t.m4
Copying file m4/visibility.m4
Copying file po/Makevars.template
autoreconf: running: /opt/local/bin/aclocal --force -I m4 -I src/libopts/m4 -I src/gl/m4 -I lib/unistring/m4 --install
aclocal: installing 'm4/ax_ac_append_to_file.m4' from '/opt/local/share/aclocal/ax_ac_append_to_file.m4'
aclocal: installing 'm4/ax_ac_print_to_file.m4' from '/opt/local/share/aclocal/ax_ac_print_to_file.m4'
aclocal: installing 'm4/ax_add_am_macro_static.m4' from '/opt/local/share/aclocal/ax_add_am_macro_static.m4'
aclocal: installing 'm4/ax_am_macros_static.m4' from '/opt/local/share/aclocal/ax_am_macros_static.m4'
aclocal: installing 'm4/ax_check_gnu_make.m4' from '/opt/local/share/aclocal/ax_check_gnu_make.m4'
aclocal: overwriting 'm4/ax_code_coverage.m4' with '/opt/local/share/aclocal/ax_code_coverage.m4'
aclocal: installing 'm4/ax_file_escapes.m4' from '/opt/local/share/aclocal/ax_file_escapes.m4'
aclocal: overwriting 'm4/pkg.m4' with '/opt/local/share/aclocal/pkg.m4'
autoreconf: configure.ac: tracing
autoreconf: running: /opt/local/bin/glibtoolize --copy --force
glibtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
glibtoolize: copying file 'build-aux/ltmain.sh'
glibtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
glibtoolize: copying file 'm4/libtool.m4'
glibtoolize: copying file 'm4/ltoptions.m4'
glibtoolize: copying file 'm4/ltsugar.m4'
glibtoolize: copying file 'm4/ltversion.m4'
glibtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /opt/local/bin/autoconf --force
autoreconf: running: /opt/local/bin/autoheader --force
autoreconf: running: /opt/local/bin/automake --add-missing --copy --force-missing
configure.ac:41: installing 'build-aux/compile'
configure.ac:31: installing 'build-aux/missing'
doc/Makefile.am: installing 'build-aux/depcomp'

[Schamschula (Marius Schamschula)]

The problem seems to be

aclocal: overwriting 'm4/ax_code_coverage.m4' with '/opt/local/share/aclocal/ax_code_coverage.m4'

How do I disable this?

[Schamschula (Marius Schamschula)]

It looks like you have autoconf-archive installed! This is the difference amongst my machines!

[mmilenko]

Yes, I do have autoconf-archive installed.

[kencu (Ken)]

I was having a different error that I could not make any headway with on 10.6.8:

--->  Building gnutls
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_gnutls/gnutls/work/gnutls-3.6.6" && /usr/bin/make -j4 -w all 
make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_gnutls/gnutls/work/gnutls-3.6.6'
Makefile:2060: *** missing separator.  Stop.
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_gnutls/gnutls/work/gnutls-3.6.6'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_gnutls/gnutls/work/gnutls-3.6.6" && /usr/bin/make -j4 -w all 
Exit code: 2
Error: Failed to build gnutls: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_gnutls/gnutls/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.

but on a prayer, I tried disabling autoconf-archive and it worked to fix the build when nothing else would.

[Schamschula (Marius Schamschula)]

Ken,

You saw the same error:

Makefile:2060: *** missing separator. Stop.

is all you see printed out w/o looking at main.log.

[Schamschula (Marius Schamschula)]

In 8155cec252ccee5f698ea531712a8407107fcaaa/macports-ports (master):

gnutls: add autoconf-archive to conflicts_build

Closes: #57958