Opened 6 years ago

Closed 6 years ago

#58058 closed defect (fixed)

elvis fails to build on Mojave

Reported by: Crosmatron Owned by: Crosmatron
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: jmroot (Joshua Root)
Port: elvis

Description

elvis fails to build because it tries to declare its own memmove 

:info:build need.c:31:7: error: expected parameter declarator
:info:build void *memmove(void *dest, const void *src, size_t size)

Attachments (4)

patch-src-need.c.diff​ (754 bytes) - added by Crosmatron 6 years ago.
Portfile-elvis.diff​ (419 bytes) - added by Crosmatron 6 years ago.
Portfile.diff​ (710 bytes) - added by jmroot (Joshua Root) 6 years ago.
configure.diff​ (4.4 KB) - added by jmroot (Joshua Root) 6 years ago.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by Crosmatron

Attachment: patch-src-need.c.diff​ added

comment:1 Changed 6 years ago by mf2k (Frank Schima)

Keywords: maintainer added

Some comments:

  • Since this is fixing a build failure, the revision does not need to be increased.
  • Your GitHub username needs to be added to maintainers.

Changed 6 years ago by Crosmatron

Attachment: Portfile-elvis.diff​ added

comment:2 Changed 6 years ago by Crosmatron

Ok, I've uploaded a new Portfile diff that doesn't change the revision.

Changed 6 years ago by jmroot (Joshua Root)

Attachment: Portfile.diff​ added

Changed 6 years ago by jmroot (Joshua Root)

Attachment: configure.diff​ added

comment:3 Changed 6 years ago by jmroot (Joshua Root)

This happens because the configure script assumes that the system headers exist in /usr/include. Enabling verbose configure output shows that there are several other checks that it is getting wrong too. I would suggest fixing it by patching in the SDK path as in the attached diffs.

comment:4 Changed 6 years ago by jmroot (Joshua Root)

Cc: jmroot added

comment:5 Changed 6 years ago by Crosmatron

jmroot's patch is better than what I did. Can we get that accepted?

comment:6 Changed 6 years ago by jmroot (Joshua Root)

Resolution: → fixed
Status: assigned → closed

In 30aa660716c355f7abe4b8ff0d13e54be9d696b6/macports-ports (master):

elvis: fix build on Mojave

Closes: #58058

Note: See TracTickets for help on using tickets.