Opened 6 years ago
Closed 6 years ago
#58097 closed enhancement (fixed)
carthage @0.31.2: add shell completions
| Reported by: | FranklinYu (Franklin Yu) | Owned by: | saagarjha (Saagar Jha) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | carthage |
Description
It was mentioned in #57923 that the Bash/Zsh/Fish shell completions are missing in the port. In contrast, they are included in Homebrew package.
Change History (9)
comment:1 Changed 6 years ago by mf2k (Frank Schima)
| Keywords: | bash zsh fish removed |
|---|
comment:2 Changed 6 years ago by saagarjha (Saagar Jha)
comment:3 Changed 6 years ago by saagarjha (Saagar Jha)
Actually, scratch that, I can't build Carthage because of https://github.com/Carthage/Carthage/issues/2694 :/
comment:4 Changed 6 years ago by FranklinYu (Franklin Yu)
Yes, we can wait for the issue to be solved.
Meanwhile just FYI: port subversion puts Bash completion at $prefix/etc/bash_completion.d/; port zsh-completions puts files in $prefix/share/zsh/site-functions/.
comment:5 Changed 6 years ago by FranklinYu (Franklin Yu)
Wait, that issue is about Xcode Beta 10.2. So your computer don’t have the stable Xcode? Carthage should be able to build in Xcode 10.1 (current stable).
comment:6 Changed 6 years ago by saagarjha (Saagar Jha)
Yeah, I always run beta versions. I've already made the changes locally, so I can push them if you want to look at them.
comment:8 Changed 6 years ago by saagarjha (Saagar Jha)
Thanks for the ping; I've filed a pull request (https://github.com/macports/macports-ports/pull/4019). I haven't really tested the zsh and fish completions, since I don't use those shells, but I think they should work.
comment:9 Changed 6 years ago by saagarjha (Saagar Jha)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Hang on, let me figure out how zsh and fish handle completion and I'll create a revision that fixes this.