Opened 6 years ago

Closed 6 years ago

#58099 closed defect (fixed)

ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of wrong patch for src/subprocess-posix.cc

Reported by: ballapete (Peter "Pete" Dyballa) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.5.4
Keywords: tiger haspatch Cc: kencu (Ken)
Port: ninja

Description

Ninja 1.9.0 has new code in src/subprocess-posix.cc so the old patch fails. With the new patch it builds and allows to build meson.

Attachments (1)

patch-tiger-no-posix-spawn-2.diff​ (5.2 KB) - added by ballapete (Peter "Pete" Dyballa) 6 years ago.
Patchset for Ninja 1.9.0

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by ballapete (Peter "Pete" Dyballa)

Attachment: patch-tiger-no-posix-spawn-2.diff​ added

Patchset for Ninja 1.9.0

comment:1 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: kencu added; ryandesign@… removed
Keywords: haspatch added
Owner: set to ryandesign
Status: new → assigned

Ken, any comment? This was your patch.

comment:2 Changed 6 years ago by kencu (Ken)

Will check.

comment:3 Changed 6 years ago by ken-cunningham-webuse

Resolution: → fixed
Status: assigned → closed

In 26de0bb48f12cafe3af73aad3d342f51c06c4675/macports-ports (master):

ninja: freshen Tiger patch

all tests pass
closes: #58099

I'd like to add the posix_spawn functions to legacysupport if possible.
Otherwise, perhaps we might be able to get upstream to accept
a version of subprocess_posix.cc that continues to use fork() if
posix_spawn is not available.

Note: See TracTickets for help on using tickets.