#58336 closed enhancement (fixed)
wireshark: remove old ones
Reported by: | ra1nb0w | Owned by: | ghosthound |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | opendarwin.org@…, hsivank@… | |
Port: | wireshark wireshark2 wireshark22 wireshark24 |
Description
What do you think about removing old wireshark ports, like:
- wireshark
- wireshark-devel
- wireshark22
and maybe create a meta package that point to the latest one.
Change History (20)
comment:1 Changed 6 years ago by jmroot (Joshua Root)
Cc: | opendarwin.org@… hsivank@… added |
---|
comment:2 Changed 6 years ago by mf2k (Frank Schima)
Port: | wireshark wireshark2 wireshark22 wireshark24 added |
---|---|
Type: | request → enhancement |
Version: | 2.5.4 |
comment:3 Changed 6 years ago by ra1nb0w
is there in macports a waiting period from the request to the remove?
comment:4 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)
These ports have a listed maintainer. It is customary to allow the maintainer 72 hours to respond to a ticket.
comment:5 follow-up: 11 Changed 6 years ago by kencu (Ken)
wireshark22 appears to be the last version that supports qt4, so if it's not any trouble, I'd ask to leave that one behind for systems that can't presently do qt5.
$ port -v installed wireshark22 The following ports are currently installed: wireshark22 @2.2.10_1+cares+geoip+gnutls+kerberos5+libgcrypt+libsmi+portaudio+qt4+zlib-qt5 (active) platform='darwin 10' archs='x86_64' date='2019-04-14T22:13:17-0700'
we could change the default to +qt4 for such systems as well to make it easy to see.
comment:6 Changed 6 years ago by ghosthound
Please do not remove any of the ports listed without maintainer approval. I think this will take a bit for people to see it and add comments (such as the above about wireshark22 being the last to support Qt4).
comment:8 Changed 6 years ago by ghosthound
Owner: | set to ghosthound |
---|---|
Status: | new → accepted |
comment:10 Changed 6 years ago by ghosthound
The more I think about removing the old wireshark ports, the less I like the idea, mostly for the case outlined above for those that need support for older hardware or similar. What's the compelling reason to remove the older versions?
So far as wireshark-devel goes, I agree with either updating it to current -dev or removing it, but that one isn't mine so I'll leave it up to the maintainer to decide.
comment:11 Changed 6 years ago by ghosthound
Replying to kencu:
wireshark22 appears to be the last version that supports qt4, so if it's not any trouble, I'd ask to leave that one behind for systems that can't presently do qt5.
$ port -v installed wireshark22 The following ports are currently installed: wireshark22 @2.2.10_1+cares+geoip+gnutls+kerberos5+libgcrypt+libsmi+portaudio+qt4+zlib-qt5 (active) platform='darwin 10' archs='x86_64' date='2019-04-14T22:13:17-0700'we could change the default to +qt4 for such systems as well to make it easy to see.
Done - wireshark22 now defaults to +qt4, thanks for the info.
comment:12 Changed 6 years ago by ra1nb0w
Why not discuss the PR that has (also) that change?
Why remove: because they are outdated, not maintained and with many many CVEs.
comment:13 Changed 6 years ago by mf2k (Frank Schima)
I don't see the point for keeping old versions around. If you want to support old versions of macOS, then let's just keep wireshark22 with qt4 and remove any variants on it.
comment:14 Changed 6 years ago by kencu (Ken)
FYI, wireshark3 builds just great on 10.6.8 with qt5.3, and the interface is very fast and snappy.
$ port -v installed wireshark3 The following ports are currently installed: wireshark3 @3.0.1_1+cares+geoip+gnutls+kerberos5+libgcrypt+libsmi+python37+qt5+zlib (active) platform='darwin 10' archs='x86_64' date='2019-04-25T13:06:48-0700'
comment:15 Changed 6 years ago by ra1nb0w
Is there a general policy on which is the minimum OS that macports need to support? Like, 10.4 with PPC.
Otherwise we can remove all except wireshark2 and wireshark3 (upstream supported).
comment:16 Changed 6 years ago by mf2k (Frank Schima)
The only actual policy is that we support the current and 2 earlier versions of macOS.
comment:17 Changed 6 years ago by kencu (Ken)
Please don't be too rigorous with that policy. It is meant to hold maintainers to the responsibility of keeping current ports working on the past two systems. It is not meant to tell maintainers they are supposed to remove things that are working perfectly well for people on older systems.
Homebrew has 10 times MacPorts' following. We have a few unique features to add, and one of the biggest ones is MacPorts' support for older systems is extremely robust.
comment:18 Changed 6 years ago by ra1nb0w
Sure; the Apple decision to maintain only the last three version, now corresponds to 3 years, is quite short.
But from 10.6 on seems good to me for wireshark; you can always use tcpdump or other pcap tools to capture and then move the result to analyse.
In general, I don't like to have unsupported packages (with many vulnerabilities like wireshark) that have newer versions that works fine. Moreover I think that we don't need to confuse the user with too many versions.
comment:19 Changed 6 years ago by ra1nb0w
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
I think wireshark24 should also be removed. wireshark-devel should be updated to the latest development release or be removed.