Opened 6 years ago

Closed 5 years ago

#58343 closed defect (fixed)

py-tornado: 6.x breaks compatibility with mitmproxy

Reported by: yan12125 (Chih-Hsuan Yen) Owned by: stromnov (Andrey Stromnov)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: petrrr
Port: py-tornado, py-mitmproxy

Description

In ​https://github.com/macports/macports-ports/commit/5cffb2c8a0334c4c98ac5461948185dbb8f672ad, I added a patch to make py-mitmproxy compatible with py-tornado 6.x, and the patch turns out to confuse users (1).

Could you consider reverting py-tornado to 5.x so that mitmproxy can work as good as usual?

(1) ​https://github.com/mitmproxy/mitmproxy/issues/3513

Change History (1)

comment:1 Changed 5 years ago by yan12125 (Chih-Hsuan Yen)

Resolution: → fixed
Status: assigned → closed

In db19162fb74912f6143579a7949cb520175f0c6f/macports-ports (master):

py-mitmproxy: add a variant to enable the onboarding app via older Tornado

Bump revision so that all mitmproxy users will know the current
situation.

Ref: ​https://github.com/mitmproxy/mitmproxy/issues/3513
Closes: #58343

Note: See TracTickets for help on using tickets.