wireshark ports: depends on incorrect qt5 version on older OS versions

[dzhub]

Hi there,

today I tried to install Wireshark3 on a Mac running macOS 10.11.6 (2,8 GHz Quad-Core Intel Xeon). Is there something I can do about this:

--->  Fetching archive for qt5-qtbase
--->  Attempting to fetch qt5-qtbase-5.12.2_0+openssl.darwin_15.x86_64.tbz2 from https://packages.macports.org/qt5-qtbase
--->  Attempting to fetch qt5-qtbase-5.12.2_0+openssl.darwin_15.x86_64.tbz2 from http://lil.fr.packages.macports.org/qt5-qtbase
--->  Attempting to fetch qt5-qtbase-5.12.2_0+openssl.darwin_15.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/qt5-qtbase
--->  Fetching distfiles for qt5-qtbase
Error: qt5-qtbase requires macOS 10.12 or later
Error: Failed to fetch qt5-qtbase: incompatible OS version
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_aqua_qt5/qt5-qtbase/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port wireshark3 failed

Thank you for any hints.

[jmroot (Joshua Root)]

From what I understand, ports using Qt 5 are expected to use the qt5 portgroup in order to depend on the correct version based on the OS version (e.g. qt511-* on 10.11).

[jmroot (Joshua Root)]

This actually applies to most of the wireshark ports.

[ghosthound]

The wireshark ports do use "PortGroup qt5 1.0" - see the qt5 variant. What might be incorrect is the use of "depends_lib-append" for qt5 components, I'll look at changing those over to use "qt5.depends_component"

[jmroot (Joshua Root)]

Right, the portgroup is included but not used to declare the qt5-* dependencies. The patch I attached seems to change the deps correctly with an older os.major.

[cjones051073 (Chris Jones)]

I actually committed fixes for this yesterday. E.g.

[52d63c0d74622e1564ac52401e8c6c47912b2538/macports-ports]

Apologies for bypassing trac, but I failed to notice this ticket, and as it was a clear bug fix to currently broken platforms, I thought it acceptable to commit directly. Apologies if you disagree.

As a side comment, unless you really strongly object, please consider making the wireshark ports openmaintainer. We tend to prefer this, unless there are good reasons not to.

[ghosthound]

Replying to cjones051073:

I actually committed fixes for this yesterday. E.g.

[52d63c0d74622e1564ac52401e8c6c47912b2538/macports-ports]

Apologies for bypassing trac, but I failed to notice this ticket, and as it was a clear bug fix to currently broken platforms, I thought it acceptable to commit directly. Apologies if you disagree.

As a side comment, unless you really strongly object, please consider making the wireshark ports openmaintainer. We tend to prefer this, unless there are good reasons not to.

Please don't make commits against ports that are not (no|open)maintainer.