Opened 6 years ago
Closed 6 years ago
#58359 closed defect (fixed)
Homebank @5.2.2 updating a port to a newer upstream version
Reported by: | sibador (Julien BARBEY) | Owned by: | chrstphrchvz (Christopher Chavez) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch maintainer | Cc: | chrstphrchvz (Christopher Chavez) |
Port: | homebank |
Description
Hello
I updated from version 5.2.2 to 5.2.4
Thank you
Attachments (1)
Change History (5)
Changed 6 years ago by sibador (Julien BARBEY)
Attachment: | homebank.diff added |
---|
comment:1 Changed 6 years ago by chrstphrchvz (Christopher Chavez)
comment:2 Changed 6 years ago by chrstphrchvz (Christopher Chavez)
Cc: | chrstphrchvz added |
---|
comment:3 Changed 6 years ago by sibador (Julien BARBEY)
Hi Christopher
Yes, I send usually send in a patchfile via Trac to update this port. I did not know that I could make the request by Github. I will follow the request on Github and for the next time I will do it by Github.
Thanhs you for information.
comment:4 Changed 6 years ago by chrstphrchvz (Christopher Chavez)
Owner: | set to chrstphrchvz |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Hi Julien, thanks for sending in the update. I am not a MacPorts member, but to help incorporate your change sooner, I have created a pull request on GitHub from your patch: https://github.com/macports/macports-ports/pull/4109
For the past year or so, MacPorts has begun accepting changes via GitHub pull requests. While patchfiles attached to tickets are definitely still accepted, MacPorts now encourages changes be sent via GitHub, since pull requests are usually processed more quickly, and build bots can test the proposed the changes on different OS and compiler versions to try catching any issues before merging.
I understand you usually send in a patchfile via Trac to update this port, so I wanted to point out the option of submitting on GitHub in case you weren't aware.
Hope this helps!