libiconv +cp932fix fails in patch phase

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

The recent update to libiconv, from a ​pull request, seems to have broken libiconv +cp932fix. The patchfile no longer applies.

[chrstphrchvz (Christopher Chavez)]

I did not try compiling the +cp932fix variant, so I did not notice this issue earlier.

I believe this is the upstream change in 1.16 that broke the patch: ​https://git.savannah.gnu.org/cgit/libiconv.git/commit/tests/Makefile.in?id=1badfd5d85cedfe06a2d8262f0ae91b121e86fa5

Since the patch is not in macports-ports, how should this be resolved? The patch is from over 12 years ago ([2f85b61c43/macports-ports]), is it still needed?

[ryandesign (Ryan Carsten Schmidt)]

Replying to chrstphrchvz:

Since the patch is not in macports-ports, how should this be resolved?

See #36921 for an example of how I solved a similar problem with the suhosin variant/patch in the php port.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

I have opened a ​pull request to remove the cp932fix variant.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

In 0e53304b6930f96bbb89bee1eef0e525bb9192e0/macports-ports (master):

libiconv: remove cp932fix variant

The cp932fix patch is quite old and no longer applies.
Fixes #58523

[ryandesign (Ryan Carsten Schmidt)]

In 7bf3e59a0347141083c6c10312c85e76c82dd48c/macports-ports (master):

libiconv: Remove stray backslash and patch_sites

Both were leftover after removing the cp932fix variant.

See: #58523

[ryandesign (Ryan Carsten Schmidt)]

In ccdb2539719d5d9eef5ef4b3adbdb82dc01a9af7/macports-ports (master):

libiconv: No longer use -p1 for patches

This is no longer needed now that the cp932fix patch is gone.

See: #58523