Opened 5 years ago

Last modified 5 years ago

#58523 closed defect

libiconv +cp932fix fails in patch phase — at Version 2

Reported by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: chrstphrchvz (Christopher Chavez)
Port: libiconv

Description (last modified by ryandesign (Ryan Carsten Schmidt))

The recent update to libiconv, from a ​pull request, seems to have broken libiconv +cp932fix. The patchfile no longer applies.

Change History (2)

comment:1 Changed 5 years ago by chrstphrchvz (Christopher Chavez)

I did not try compiling the +cp932fix variant, so I did not notice this issue earlier.

I believe this is the upstream change in 1.16 that broke the patch: ​https://git.savannah.gnu.org/cgit/libiconv.git/commit/tests/Makefile.in?id=1badfd5d85cedfe06a2d8262f0ae91b121e86fa5

Since the patch is not in macports-ports, how should this be resolved? The patch is from over 12 years ago ([2f85b61c43/macports-ports]), is it still needed?

comment:2 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Note: See TracTickets for help on using tickets.