build error at libuv

[ClausKlein]

:info:build Undefined symbols for architecture i386:
:info:build   "_close$NOCANCEL", referenced from:
:info:build       _uv__close_nocancel in libuv_la-core.o
:info:build       _uv__close_nocheckstdio in libuv_la-core.o
:info:build ld: symbol(s) not found for architecture i386
:info:build clang: error: linker command failed with exit code 1 (use -v to see invocation)
:info:build make: *** [libuv.la] Error 1
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libuv/libuv/work/libuv-1.29.1'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libuv/libuv/work/libuv-1.29.1" && /usr/bin/make -j2 -w all 
:info:build Exit code: 2
:error:build Failed to build libuv: command execution failed

[kencu (Ken)]

hmmmm. I fixed this already, I thought. the fix has also been sent upstream. <​https://github.com/macports/macports-ports/commit/1735bb1417aa634f94d7127c4c127f3d5f50e8e9#diff-64e1498b68963c990f644d9dd9ed1f29>.

perhaps selfupdate and try again.

[michaelld (Michael Dickens)]

@kencu: this is 10.11 ... and +universal ... let me try this on my equivalent OSX boot bot & see what happens ...

[michaelld (Michael Dickens)]

@ClausKlein : If you don't require +universal, I'd advise you to not use it ...

[kencu (Ken)]

yes, but i set the patch to apply there as well. I did test it universal on several systems.

[michaelld (Michael Dickens)]

FYI I see the exact same error when I build as +universal on 10.11.

I don't generally do +universal, since it's such a can of worms! Luckily, libuv doesn't have a lot of dependencies ...

[kencu (Ken)]

perhaps check then that patch is actually being applied? it should be calling for the 32b symbol as per the patch.

[kencu (Ken)]

looks like the devel port is not using the patch...the PR btw is still being reviewed upstream

[michaelld (Michael Dickens)]

Yeah I think I was trying the devel port. I'm rechecking with the release version, and verified that the patch is definitely applied (yes, it is!).

[michaelld (Michael Dickens)]

What's the upstream PR link?

[michaelld (Michael Dickens)]

OK the release version builds as +universal for me. Guessing I was trying the devel before.

[michaelld (Michael Dickens)]

Thus, I think the solution is for @ClausKlein to do:

sudo port clean libuv
sudo port selfupdate
sudo port install libuv +universal

and, that should work & allow more updating / progress installing / whatever use of MacPorts is going on.

[kencu (Ken)]

upstream pr <​https://github.com/libuv/libuv/pull/2309>

[ClausKlein]

Thanks, that works

[michaelld (Michael Dickens)]

@ClausKlein: Great! Thanks for reporting back!