Opened 5 years ago

Closed 5 years ago

#58665 closed defect (duplicate)

octave portgroup's post-extract phase conflicts with macports master

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.5.99
Keywords: Cc: slewsys (Andrew L. Moore), michaelld (Michael Dickens), Schamschula (Marius Schamschula)
Port: octave

Description

The octave portgroup mucks with the directory name after extraction:

post-extract {
    # rename the effective worksrcdir to always be ${octave.module}

    set worksrcdir_name [exec /bin/ls ${workpath} | grep -v -E "^\\."]
    if {[string equal ${worksrcdir_name} ${octave.module}] == 0} {
        # work-around for case-insensitive file systems when the
        # extract directory name is the same as the octave module name
        # except for letter case; should always work no matter if the
        # file system is case-insensitive or case-sensitive.

        move ${workpath}/${worksrcdir_name} ${workpath}/tmp-${worksrcdir_name}
        move ${workpath}/tmp-${worksrcdir_name} ${workpath}/${octave.module}
    }
}

This (especially its use of ls and its assumption that there will only be one line of output) does not work when used with MacPorts master (2.5.99) which uses a different approach to fix the worksrcdir (creating a symlink if necessary). The octave portgroup needs to become compatible with this new approach, while remaining compatible with released versions of MacPorts 2.5.x until 2.6 comes out with the fixes from master.

Change History (3)

comment:1 Changed 5 years ago by Schamschula (Marius Schamschula)

Cc: Schamschula added

comment:2 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)

Now that MacPorts 2.6.0 has been released, the portgroup no longer needs to maintain compatibility with MacPorts 2.5.x. It only needs compatibility with 2.6.0. Possibly by simply removing most of the code in the post-extract phase.

comment:3 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: duplicate
Status: newclosed

This was solved in #59111.

Note: See TracTickets for help on using tickets.