Opened 5 years ago
Closed 5 years ago
#58743 closed defect (fixed)
py-language-server requires older version of py-jedi
Reported by: | amake (Aaron Madlon-Kay) | Owned by: | reneeotten (Renee Otten) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | stromnov (Andrey Stromnov) | |
Port: | py-language-server |
Description
py-language-server 0.27.0 requires jedi <0.14,>=0.13.2
but the latter port (py-jedi) has been updated to 0.14.1 so currently the former just doesn't work.
There doesn't seem to be an easy fix:
- py-language-server specifies
<0.14
due to legitimate bugs, so it doesn't make sense to patch the restriction out - There is no version of py-language-server that works with jedi 0.14+ (the former is up to date with upstream)
What is our policy here? It seems the options are:
- Wait for py-language-server to support jedi 0.14+
- Downgrade py-jedi
- Provide a separate py-jedi13 port
Attachments (2)
Change History (5)
comment:1 Changed 5 years ago by reneeotten (Renee Otten)
Changed 5 years ago by reneeotten (Renee Otten)
Changed 5 years ago by reneeotten (Renee Otten)
Attachment: | patch-setup.py.diff added |
---|
comment:2 Changed 5 years ago by reneeotten (Renee Otten)
I have made the same change is in that PR to the setup.py file and our Portfile (see attachements above). However, there are a few test failures so I don't think it will actually work but feel free to try. I asked upstream if they know what else needs to be done to support jedi 0.14.1 and/or what their timeline for a new release is - let's see what they say and take it from there.
comment:3 Changed 5 years ago by reneeotten (Renee Otten)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
it appears that there is a PR for py-langauage-server that increases the supported jedi version, so that version 0.14.1 should work. It has not been merged yet upstream though.
I will take a look tomorrow if it is indeed as simple as just changing the version specifiers in setup.py or if there are some other commits that one would need to include as well. You have listed the options in order of preferences, at least for me and I think we should go with options 1, hopefully that proves doable. I disagree with option 3 and downgrading ports should only be done in exceptional cases, so let's see if that can be avoided.