Opened 5 years ago
Closed 5 years ago
#58825 closed defect (fixed)
PortIndex on mirrors has incorrect version for iTerm2
Reported by: | yan12125 (Chih-Hsuan Yen) | Owned by: | markemer (Mark Anderson) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ||
Port: | iTerm2 |
Description
$ rsync rsync://rsync.macports.org/macports/release/tarballs/PortIndex_darwin_18_i386/PortIndex . $ grep iTerm2 PortIndex | tr ' ' '\n' | grep -A 1 version version 3.2.0
The iTerm2 version should be 3.2.9 (as of writing) instead of 3.2.0. A direct impact is that port outdated
gets broken:
$ port -v outdated The following installed ports are outdated: iTerm2 3.2.9_0 > 3.2.0_0 !
Seems those PortIndex files are generated by mprsyncup (1), so the cause might be that portindex fails to map the -p
argument to ${os.version}
(2) used in iTerm2's Portfile (3).
Also ping the maintainer of iTerm2.
(1) https://github.com/macports/macports-infrastructure/blob/master/jobs/mprsyncup
(2) https://github.com/macports/macports-base/blob/master/src/port/portindex.tcl#L236
(3) https://github.com/macports/macports-ports/blob/master/aqua/iTerm2/Portfile#L11
Change History (8)
comment:1 Changed 5 years ago by mf2k (Frank Schima)
Cc: | markemer removed |
---|---|
Component: | base → ports |
Owner: | set to markemer |
Status: | new → assigned |
comment:2 Changed 5 years ago by markemer (Mark Anderson)
comment:3 Changed 5 years ago by jmroot (Joshua Root)
It would be less complicated to use os.major anyway.
comment:4 Changed 5 years ago by markemer (Mark Anderson)
Good eye. I didn't write that code, I actually use os.major below that line. I can tinker with that and make sure it works.
comment:6 Changed 5 years ago by markemer (Mark Anderson)
Yeah, let me look - I had forgotten about this.
comment:7 Changed 5 years ago by markemer (Mark Anderson)
I put up https://github.com/macports/macports-ports/pull/5506 to fix this.
comment:8 Changed 5 years ago by yan12125 (Chih-Hsuan Yen)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
$ rsync rsync://rsync.macports.org/macports/release/tarballs/PortIndex_darwin_18_i386/PortIndex . $ grep iTerm2 PortIndex | tr ' ' '\n' | grep -A 1 version version 3.3.5
Now fixed, thank you for the efforts!
This is weird. I'll take a look.