Opened 5 years ago
Closed 4 years ago
#58887 closed defect (fixed)
libpcl update to 1.9.1_1 fails
| Reported by: | dershow | Owned by: | Veence (Vincent) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | libpcl |
Description
I had 1.9.1 installed but the upgrade to 1.9.1_1 fails to build. I've attached the logfile
Attachments (2)
Change History (14)
Changed 5 years ago by dershow
comment:1 Changed 5 years ago by mf2k (Frank Schima)
| Cc: | Veence removed |
|---|---|
| Owner: | set to Veence |
| Status: | new → assigned |
comment:2 Changed 5 years ago by dershow
comment:3 Changed 5 years ago by dershow
I just tried to clean and rebuild libpcl 1.9.1 and this time, I got an error:
---> Configuring libpcl Error: Failed to configure libpcl: vtk must be installed with +qt5.
So, I rebuilt vtk with the +qt5 variant. Macports then found that libpcl was broken (as expected) and tried to rebuild it. But, it again failed to build. As it stopped in a different place, I am attaching the newer log file as well.
comment:5 Changed 4 years ago by dershow
I just migrated to 10.15, and still can't get libpcl to build.
comment:6 Changed 4 years ago by reneeotten (Renee Otten)
it seems related to boost so perhaps this PR fixes it? Please comment here whether you can confirm that it does solve the problem - if so, I think we should just merge that PR as the maintainer didn't respond to it for about two months now.
comment:7 follow-up: 8 Changed 4 years ago by dershow
I just changed my local port as indicated in the PR (I think) and it still gives an error. To be clear, I changed my port to: compiler.openmp_version 3.1 (and the associated deletes). I do have boost 1.71.0_2 installed. I didn't do anything with vtk that is also mentioned in that link.
I'm not sure if anything else is being suggested in the PR.
comment:8 Changed 4 years ago by reneeotten (Renee Otten)
Replying to dershow:
I just changed my local port as indicated in the PR (I think) and it still gives an error. To be clear, I changed my port to: compiler.openmp_version 3.1 (and the associated deletes). I do have boost 1.71.0_2 installed. I didn't do anything with vtk that is also mentioned in that link.
I'm not sure if anything else is being suggested in the PR.
Just to be completely sure... you did add the patchfile that is supposedly solving the issue with newer versions of boost - that's the important point of the PR?
comment:9 follow-up: 10 Changed 4 years ago by dershow
No, I did not. It wasn't clear to me exactly what to change. All I tried was a change to my local libpcl/Portfile Where should the patchfile go? Just save it in /libpcl/files/boost170.patch ?
Although, at the moment I see that the PR is showing an error and is waiting for a review. So, I'm not sure what is useful for to try now.
comment:10 Changed 4 years ago by reneeotten (Renee Otten)
Replying to dershow:
No, I did not. It wasn't clear to me exactly what to change. All I tried was a change to my local libpcl/Portfile Where should the patchfile go? Just save it in /libpcl/files/boost170.patch ?
Although, at the moment I see that the PR is showing an error and is waiting for a review. So, I'm not sure what is useful for to try now.
okay, then it's no wonder that it didn't help ;)
Yes, you download the boost170.patch file and copy it to you local libpcl/files directory, and additionally add the line patchfiles-append boost170.patch in your local Portfile.
The CI systems will never finish because the port needs a dependency with a non-default variant (i.e., vtk +qt5). Ideally the PR should have been reviewed a while ago; I just requested it again today so that the maintainer gets notified. It would be helpful if you can try, if it solves the issue that's another positive data point to merge the PR. Thanks!
comment:11 Changed 4 years ago by dershow
I already had vtk +qt5 installed. And, with the above patch file, it did complete the build without errors.
comment:12 Changed 4 years ago by reneeotten (Renee Otten)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I've merged the PR so this should be fixed with this commit.
I did recently upgrade xcode, so I figured I would retry this build. It downloaded llvm-9.0 and clang-9.0 but then failed once it tried to build again.