port@2.5.99 does not build clang-8.0.0_1; port@2.5.4 does build it and so does the buildbot

[snowflake (Dave Evans)]

macports-base checkout:

50f29345cb9208d49a45282aba6a0de37950aa29

macports-ports checkout:

4bc7781bc69a888a068e8b1a5439166c8e37d4ee

Environment:

DEBUG: OS X 10.11 (darwin/15.6.0) arch i386
DEBUG: MacPorts 2.5.99
DEBUG: Xcode 8.2.1
DEBUG: SDK 10.11
DEBUG: MACOSX_DEPLOYMENT_TARGET: 10.11

Failing command:

[ 34%] Building CXX object projects/compiler-rt/lib/xray/CMakeFiles/RTXrayFDR.os
x.dir/xray_fdr_logging.cc.o
cd /opt/local/var/macports/build/_Users_davidevans_macports_sources_github.com_m
acports_macports-ports_lang_llvm-8.0/clang-8.0/work/build/projects/compiler-rt/l
ib/xray && /usr/bin/clang++  -DXRAY_HAS_EXCEPTIONS=1 -D__STDC_CONSTANT_MACROS -D
__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/opt/local/var/macports/build/_User
s_davidevans_macports_sources_github.com_macports_macports-ports_lang_llvm-8.0/c
lang-8.0/work/build/projects/compiler-rt/lib/xray -I/opt/local/var/macports/buil
d/_Users_davidevans_macports_sources_github.com_macports_macports-ports_lang_llv
m-8.0/clang-8.0/work/llvm-8.0.0.src/projects/compiler-rt/lib/xray -I//opt/local/
include/libxml2 -I/opt/local/var/macports/build/_Users_davidevans_macports_sourc
es_github.com_macports_macports-ports_lang_llvm-8.0/clang-8.0/work/build/include
 -I/opt/local/var/macports/build/_Users_davidevans_macports_sources_github.com_m
acports_macports-ports_lang_llvm-8.0/clang-8.0/work/llvm-8.0.0.src/include -I/op
t/local/var/macports/build/_Users_davidevans_macports_sources_github.com_macport
s_macports-ports_lang_llvm-8.0/clang-8.0/work/llvm-8.0.0.src/projects/compiler-r
t/lib/xray/.. -I/opt/local/var/macports/build/_Users_davidevans_macports_sources
_github.com_macports_macports-ports_lang_llvm-8.0/clang-8.0/work/llvm-8.0.0.src/
projects/compiler-rt/lib/xray/../../include  -pipe -Os -std=c++11 -stdlib=libc++
 -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -W
no-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pe
dantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wnon-virt
ual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -Wall -std=c++11 -Wno-unu
sed-parameter -DNDEBUG -arch x86_64 -arch x86_64h    -stdlib=libc++ -mmacosx-ver
sion-min=10.9 -isysroot / -fPIC -fno-builtin -fno-exceptions -funwind-tables -fn
o-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -O3 -gli
ne-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-non-virtua
l-dtor -fno-rtti -o CMakeFiles/RTXrayFDR.osx.dir/xray_fdr_logging.cc.o -c /opt/l
ocal/var/macports/build/_Users_davidevans_macports_sources_github.com_macports_m
acports-ports_lang_llvm-8.0/clang-8.0/work/llvm-8.0.0.src/projects/compiler-rt/l
ib/xray/xray_fdr_logging.cc

Error messages for command:

In file included from /opt/local/var/macports/build/_Users_davidevans_macports_s
ources_github.com_macports_macports-ports_lang_llvm-8.0/clang-8.0/work/llvm-8.0.
0.src/projects/compiler-rt/lib/xray/xray_fdr_logging.cc:35:
/opt/local/var/macports/build/_Users_davidevans_macports_sources_github.com_macp
orts_macports-ports_lang_llvm-8.0/clang-8.0/work/llvm-8.0.0.src/projects/compile
r-rt/lib/xray/xray_fdr_controller.h:30:26: error: C++ requires a type specifier for all declarations
  int (*WallClockReader)(clockid_t, struct timespec *) = 0;
                         ^
/opt/local/var/macports/build/_Users_davidevans_macports_sources_github.com_macports_macports-ports_lang_llvm-8.0/clang-8.0/work/llvm-8.0.0.src/projects/compiler-rt/lib/xray/xray_fdr_controller.h:81:21: error: use of undeclared identifier 'CLOCK_MONOTONIC'
    WallClockReader(CLOCK_MONOTONIC, &TS);
                    ^
/opt/local/var/macports/build/_Users_davidevans_macports_sources_github.com_macports_macports-ports_lang_llvm-8.0/clang-8.0/work/llvm-8.0.0.src/projects/compiler-rt/lib/xray/xray_fdr_logging.cc:434:32: error: use of undeclared identifier 'CLOCK_REALTIME'
    int result = clock_gettime(CLOCK_REALTIME, &TS);
                               ^
/opt/local/var/macports/build/_Users_davidevans_macports_sources_github.com_macports_macports-ports_lang_llvm-8.0/clang-8.0/work/llvm-8.0.0.src/projects/compiler-rt/lib/xray/xray_fdr_logging.cc:487:58: error: use of undeclared identifier 'clock_gettime'
        FDRController<>(TLD.BQ, TLD.Buffer, *TLD.Writer, clock_gettime,
                                                         ^
4 errors generated.
make[2]: *** [projects/compiler-rt/lib/xray/CMakeFiles/RTXrayFDR.osx.dir/xray_fdr_logging.cc.o] Error 1

[snowflake (Dave Evans)]

raw log of the errors - generated 1/sep/2019

[kencu (Ken)]

see also 57130

[jmroot (Joshua Root)]

Not a base issue; clock_gettime just wasn't added until 10.12.

[jmroot (Joshua Root)]

The buildbot appears to have used the 10.12 SDK on 10.11 BTW, which means most likely xray would fail to run instead of failing to build.

[jmroot (Joshua Root)]

In 86520c04942a15c4e633061d60fcce173e8557e9/macports-ports (master):

clang-7.0, clang-8.0: disable xray on 10.11 too

It uses clock_gettime which was added in 10.12.

Closes: #58909