elinks-devel build fails

[m5comp]

elinks-devel fails to build with the following error:

make[3]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_elinks-devel/elinks-devel/work/elinks-0.12pre6/src/network/ssl'
      [CC]   src/network/ssl/socket.o
socket.c:70:25: error: incomplete definition of type 'struct ssl_st'
        ((ssl_t *) socket->ssl)->options |= SSL_OP_NO_TLSv1;
        ~~~~~~~~~~~~~~~~~~~~~~~^
/opt/local/include/openssl/ossl_typ.h:147:16: note: forward declaration of 'struct ssl_st'
typedef struct ssl_st SSL;
               ^
socket.c:148:40: error: incomplete definition of type 'struct ssl_st'
                        SSL_CTX *ctx = ((SSL *) socket->ssl)->ctx;
                                       ~~~~~~~~~~~~~~~~~~~~~^
/opt/local/include/openssl/ossl_typ.h:147:16: note: forward declaration of 'struct ssl_st'
typedef struct ssl_st SSL;
               ^
2 errors generated.
make[3]: *** [socket.o] Error 1
make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_elinks-devel/elinks-devel/work/elinks-0.12pre6/src/network/ssl'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_elinks-devel/elinks-devel/work/elinks-0.12pre6/src/network'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_elinks-devel/elinks-devel/work/elinks-0.12pre6/src'
make: *** [all-recursive] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_elinks-devel/elinks-devel/work/elinks-0.12pre6'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_www_elinks-devel/elinks-devel/work/elinks-0.12pre6" && /usr/bin/make -w all
Exit code: 2

[kencu (Ken)]

Do you feel this is sufficiently different from 58987 for a new ticket? I'm thinking if we fix 58987 then this one would likely be fixed too...

[m5comp]

I'm sorry; I did a search for tickets filed for elinks-devel and the only thing that came up was several years old.

[mf2k (Frank Schima)]

In the future, please use WikiFormatting.

[Chih-Hsuan Yen <yan12125@…>]

In 013143984f337dc4b669da6b928de244ed82dcf5/macports-ports (master):

elinks-devel: fix building with OpenSSL 1.1

Both patches are from upstream

​https://repo.or.cz/elinks.git/patch/f4a58ba3b574a478fd5954ba2c5b29e8b809ff9b
​https://repo.or.cz/elinks.git/patch/54ebe365b752f8969a67279d0d29552ab638e025

I've also tried go to the latest git commit, but the built binary
doesn't work. Random "pointer being freed was not allocated" crashes
occur.

After this commit, elinks-devel is still compatible with OpenSSL 1.0.2
as both SSL_get_SSL_CTX and SSL_set_options are available.
​https://www.openssl.org/docs/man1.0.2/man3/SSL_get_SSL_CTX.html
​https://www.openssl.org/docs/man1.0.2/man3/SSL_set_options.html

Closes: #58988

[yan12125 (Chih-Hsuan Yen)]

Thanks for the report and sorry for the inconvenience. It has been fixed - tried some random HTTPS sites it elinks works.