Opened 5 years ago

Closed 5 years ago

#59009 closed enhancement (fixed)

[openssh] fix "checking if programs using OpenSSL functions will link" configure failure

Reported by: RJVB (René Bertin) Owned by: Ionic (Mihai Moldovan)
Priority: Normal Milestone:
Component: ports Version:
Keywords: has_patch Cc:
Port: openssh

Description

Since the update to OpenSSL 1.1x the configure procedure for port:openssh has a non-fatal failure in the test checking if programs using OpenSSL functions will link. That test is in fact a test for the SSLeay_add_all_algorithms macro which no longer exists in 1.1.1c .

I haven't checked the implications of this failure (how?) but made a quick patch that updates the test so it no longer fails.

Attachments (1)

patch-openssl.diff (1.0 KB) - added by RJVB (René Bertin) 5 years ago.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by RJVB (René Bertin)

Attachment: patch-openssl.diff added

comment:1 Changed 5 years ago by Ionic (Mihai Moldovan)

Owner: set to Ionic
Status: newaccepted

comment:2 Changed 5 years ago by Mihai Moldovan <ionic@…>

Resolution: fixed
Status: acceptedclosed

In 715635bdfb881e287a52e23b298e379a4e9c03ac/macports-ports (master):

net/{openssh,ssh-copy-id}: update to 8.1p1.

Fixes: #56331
Fixes: #57025
Fixes: #58047
Fixes: #59009
Fixes: #59016

Changes:

  • Rebase patches.
  • Update to newer HPN patchset version. Based upon the 8.0p1 version 14.18 patch. Add a rebased OpenSSL-1.1-compat patch.
  • Switch to new ObjC-based Keychain integration as provided by Apple. Might fail on older platforms. If it does, we will need to bring back the old C-based implementation as an alternative for these.
  • Made the keychain integration and launchd startup patch a default one based upon request (and to be consistent with Apple's shipped OpenSSH version).
  • Portfile cleanup, don't define compile constants from outside - have autotools do that correctly.
  • Clarify where some of the patches come from - and especially for the gsskex patch that it is NOT a single patch taken from one location and rebased against the current OpenSSH version.
  • Renamed (now used) -m/-M options to -A/-K for the keychain integration.
Note: See TracTickets for help on using tickets.