Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#59032 closed defect (fixed)

librecad: broken against current Qt

Reported by: mojca (Mojca Miklavec) Owned by: reneeotten (Renee Otten)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mascguy (Christopher Nielsen)
Port: librecad

Description (last modified by mojca (Mojca Miklavec))

librecad builds are currently broken, but see https://www.mail-archive.com/bug-guix@gnu.org/msg09231.html

:info:build ui/generic/widgetcreator.cpp:59:44: error: member access into incomplete type 'QActionGroup'
:info:build         ui->categories_combobox->addItem(ag->objectName());
:info:build                                            ^
:info:build ui/generic/widgetcreator.h:9:7: note: forward declaration of 'QActionGroup'
:info:build class QActionGroup;
:info:build       ^
:info:build ui/generic/widgetcreator.cpp:233:39: error: member access into incomplete type 'QActionGroup'
:info:build     foreach (auto action, action_group->actions())
:info:build                                       ^
:info:build /opt/local/libexec/qt5/lib/QtCore.framework/Headers/qglobal.h:1029:21: note: expanded from macro 'foreach'
:info:build #    define foreach Q_FOREACH
:info:build                     ^
:info:build ui/generic/widgetcreator.h:9:7: note: forward declaration of 'QActionGroup'
:info:build class QActionGroup;
:info:build       ^
:info:build 2 errors generated.

Attachments (1)

main.log (1012.0 KB) - added by bpdegnan (Brian Degnan) 4 years ago.
LibraCAD error on: Darwin hebi.local 17.7.0 Darwin Kernel Version 17.7.0: Mon Apr 27 20:25:53 PDT 2020; root:xnu-4570.71.80~1/RELEASE_X86_64 x86_64

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by mojca (Mojca Miklavec)

Description: modified (diff)

Changed 4 years ago by bpdegnan (Brian Degnan)

Attachment: main.log added

LibraCAD error on: Darwin hebi.local 17.7.0 Darwin Kernel Version 17.7.0: Mon Apr 27 20:25:53 PDT 2020; root:xnu-4570.71.80~1/RELEASE_X86_64 x86_64

comment:2 Changed 4 years ago by bpdegnan (Brian Degnan)

Sadly, still the same issue. I uploaded the complete build log.

ui/generic/widgetcreator.cpp:59:44: error: member access into incomplete type

'QActionGroup'

ui->categories_combobox->addItem(ag->objectName());

The issue seems to be resolved with LibreCAD-devel @2.2.0-20190419_0

Last edited 4 years ago by bpdegnan (Brian Degnan) (previous) (diff)

comment:3 Changed 4 years ago by reneeotten (Renee Otten)

likely this can be fixed by applying these upstream patches - testing now...

Last edited 4 years ago by reneeotten (Renee Otten) (previous) (diff)

comment:4 Changed 4 years ago by reneeotten (Renee Otten)

Owner: set to reneeotten
Resolution: fixed
Status: newclosed

In 20d5b17416b8f4cd736a969013bb092cfd5c8c55/macports-ports (master):

LibreCAD: fix build with newer Qt

Closes: #59032

comment:5 Changed 4 years ago by reneeotten (Renee Otten)

okay, that works for me: it builds and the application runs. I pushed this change to master; so please do a sudo port selfupdate and try installing it again.

comment:6 Changed 3 years ago by mascguy (Christopher Nielsen)

We're seeing something similar now, though this time the error relates to use of QPainterPath:

lib/engine/lc_splinepoints.cpp:1564:28: error: member access into incomplete type 'QPainterPath'
        if(pdPattern[i] < 0) qPath.moveTo(QPointF(p2.x, p2.y));
                                  ^
/opt/local/libexec/qt5/lib/QtGui.framework/Headers/qmatrix.h:54:7: note: forward declaration of 'QPainterPath'
class QPainterPath;
      ^

I was able to fix LibreCAD-devel by updating to the latest commit, which includes fixes for things like this. But do we need another patch for the non-devel port?

comment:8 Changed 3 years ago by mascguy (Christopher Nielsen)

Cc: mascguy added

comment:9 Changed 3 years ago by kencu (Ken)

there are other ports with that error; the fix was just adding a header IIRC. grep the repo for QPainterPath...

Note: See TracTickets for help on using tickets.