Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#59069 closed defect (fixed)

portindex uses wrong cxx_stdlib for darwin 10,11,12?

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: jmroot (Joshua Root)
Priority: Normal Milestone: MacPorts 2.6.1
Component: base Version: 2.6.0
Keywords: haspatch Cc: jmroot (Joshua Root)
Port:

Description

Now that MacPorts 2.6.0 uses libc++ for darwin 10,11,12, isn't portindex doing the wrong thing on those versions?

https://github.com/macports/macports-base/blob/master/src/port/portindex.tcl#L224

Attachments (2)

portindex.diff (506 bytes) - added by ryandesign (Ryan Carsten Schmidt) 5 years ago.
mprsyncup.diff (890 bytes) - added by jmroot (Joshua Root) 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: portindex.diff added

comment:1 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added

I think this patch is needed. I've applied it to the buildbot machines.

comment:2 Changed 5 years ago by jmroot (Joshua Root)

Yes the default should change now, but you can choose a stdlib in the platform specifier like -p macosx_18_i386_libcxx. So mprsyncup should probably explicitly choose.

comment:3 Changed 5 years ago by jmroot (Joshua Root)

Owner: set to jmroot
Resolution: fixed
Status: newclosed

In 4bd6988cdabfa0c7470552cb305457b244e7343a/macports-base (master):

Update default stdlibs for portindex pretend mode

Fixes: #59069

comment:4 Changed 5 years ago by jmroot (Joshua Root)

Actually the stdlib goes in the middle for some reason. See attached.

Changed 5 years ago by jmroot (Joshua Root)

Attachment: mprsyncup.diff added

comment:5 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)

There's no need for mprsyncup to change, with the above fix already applied to portindex.

mprsyncup gained the ability to specify a cxx_stdlib back when we thought we were going to support multiple cxx_stdlibs on a single OS version. Since we're not going to do that, there's no reason to even keep this feature in mprsyncup.

comment:6 Changed 5 years ago by jmroot (Joshua Root)

Fair enough, just pointing out that it could be fixed without patching base.

comment:7 Changed 5 years ago by jmroot (Joshua Root)

Milestone: MacPorts 2.6.1
Note: See TracTickets for help on using tickets.