gpAdmin3: error: case value evaluates to -43, which cannot be narrowed to type 'OID' (aka 'unsigned long')

[mojca (Mojca Miklavec)]

This failure from 10.6 might be related to a strict compiler rather than old OS:

​https://build.macports.org/builders/ports-10.6_x86_64-builder/builds/204/steps/install-port/logs/stdio

	/opt/local/bin/clang++-mp-8.0 -DHAVE_CONFIG_H -I. -I.. -I../pgadmin/include/libssh2  -I../pgadmin/include -I../pgadmin/include/libssh2   -I/opt/local/include -I/opt/local/include/postgresql95 -I/opt/local/include/postgresql95/server -I/opt/local/include/postgresql95 -DHAVE_CONNINFO_PARSE -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/wx/include/osx_cocoa-unicode-3.0 -I/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -DEMBED_XRC  -arch x86_64 -I/opt/local/include/libxml2 -I/opt/local/include -I/opt/local/include/libxml2 -DHAVE_GCRYPT  -pipe -Os -stdlib=libc++ -arch x86_64 -MT frm/frmEditGrid.o -MD -MP -MF $depbase.Tpo -c -o frm/frmEditGrid.o frm/frmEditGrid.cpp &&\
	mv -f $depbase.Tpo $depbase.Po
frm/frmEditGrid.cpp:2397:10: error: case value evaluates to -43, which cannot be narrowed to type 'OID' (aka 'unsigned long') [-Wc++11-narrowing]
                                case PGOID_TYPE_SERIAL8:
                                     ^
../pgadmin/include/utils/pgDefs.h:22:45: note: expanded from macro 'PGOID_TYPE_SERIAL8'
#define PGOID_TYPE_SERIAL8                  -43L
                                            ^
frm/frmEditGrid.cpp:2401:10: error: case value evaluates to -44, which cannot be narrowed to type 'OID' (aka 'unsigned long') [-Wc++11-narrowing]
                                case PGOID_TYPE_SERIAL2:
                                     ^
../pgadmin/include/utils/pgDefs.h:23:45: note: expanded from macro 'PGOID_TYPE_SERIAL2'
#define PGOID_TYPE_SERIAL2                  -44L
                                            ^
frm/frmEditGrid.cpp:2405:10: error: case value evaluates to -42, which cannot be narrowed to type 'OID' (aka 'unsigned long') [-Wc++11-narrowing]
                                case PGOID_TYPE_SERIAL:
                                     ^
../pgadmin/include/utils/pgDefs.h:21:45: note: expanded from macro 'PGOID_TYPE_SERIAL'
#define PGOID_TYPE_SERIAL                   -42L
                                            ^
frm/frmEditGrid.cpp:3028:7: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
        if (!this)
            ~^~~~
1 warning and 3 errors generated.

It would be nice to build it against the latest postgres though. 9.5 is ooooooold.