Opened 5 years ago
Closed 3 years ago
#59287 closed enhancement (fixed)
Include the portwatcher build number in the portbuilder priority
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | admin@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | buildbot/mpbb | Version: | |
| Keywords: | Cc: | ||
| Port: |
Description
As a result of #52766, getSchedulersAndProperties assigns a priority to each portbuilder build, which getPriority interprets an integer, representing the order in which portbuilder builds should happen for this portwatcher build.
The problem is that due to #53587 we sometimes start another portwatcher before we're supposed to. Then the portbuilder builds for each of the portwatchers are mingled together, which isn't particularly correct.
A quick way to make this situation better would be to modify the priority field to be interpreted as a version number instead of an integer, assuming that python has version number comparison support. Then if portwatcher build 42 triggers 2 portbuilder builds, their priorities would be "42.1" and "42.2".
Change History (2)
comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 3 years ago by jmroot (Joshua Root)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I have made a change like this to the buildbot 2 configuration. I might be able to backport it to the buildbot 0.8 configuration, but hopefully we will migrate to buildbot 2 in the coming months.