Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#59554 closed defect (fixed)

rbmake: error: incomplete definition of type 'struct png_struct_def'

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.6.2
Keywords: Cc: mascguy (Christopher Nielsen)
Port: rbmake

Description

rbmake doesn't build:

pngimage.c:38:23: error: incomplete definition of type 'struct png_struct_def'
    if (setjmp(png_ptr->jmpbuf)) {
               ~~~~~~~^
/opt/local/include/png.h:439:16: note: forward declaration of 'struct png_struct_def'
typedef struct png_struct_def png_struct;
               ^
pngimage.c:104:23: error: incomplete definition of type 'struct png_struct_def'
    if (setjmp(png_ptr->jmpbuf)) {
               ~~~~~~~^
/opt/local/include/png.h:439:16: note: forward declaration of 'struct png_struct_def'
typedef struct png_struct_def png_struct;
               ^
2 errors generated.
make[1]: *** [pngimage.o] Error 1

It's not compatible with recent libpng. Usually this can be easily patched. Since this change in libpng was so long ago, somebody may already have a patch for this that we can find and use.

Change History (2)

comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: set to ryandesign
Resolution: fixed
Status: newclosed

In e8c2fe6ce2001f6b6f0bd7f57232ca86c17cb859/macports-ports (master):

rbmake: Fix build failures

Fix incompatibility with libpng 1.5 and later (use of the now-private
jmpbuf field).

Closes: #59554

Fix incompatibility with Xcode 12 and later (implicit declaration of
functions).

comment:2 Changed 3 years ago by mascguy (Christopher Nielsen)

Cc: mascguy added
Note: See TracTickets for help on using tickets.