#59585 closed defect (fixed)
ola @0.10.7 +libftdi0: error: use of undeclared identifier 'GOOGLE_CHECK'
Reported by: | fdstevex (Steve Tibbett) | Owned by: | peternewman (Peter Newman) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | mlohrey1 | |
Port: | ola |
Description (last modified by jmroot (Joshua Root))
As the summary says .. attempting to install ola with support for the Enttec Open DMX USB adapter on the Mac which requires the libftdi0 variant.
Full log attached. Summary:
sudo port install ola +libftdi0 Password: ---> Computing dependencies for ola ---> Fetching archive for ola ---> Attempting to fetch ola-0.10.7_1+http+libftdi0+libusb+osc+python27.darwin_19.x86_64.tbz2 from https://packages.macports.org/ola ---> Attempting to fetch ola-0.10.7_1+http+libftdi0+libusb+osc+python27.darwin_19.x86_64.tbz2 from http://ywg.ca.packages.macports.org/mirror/macports/packages/ola ---> Attempting to fetch ola-0.10.7_1+http+libftdi0+libusb+osc+python27.darwin_19.x86_64.tbz2 from http://aus.us.packages.macports.org/macports/packages/ola ---> Building ola Error: Failed to build ola: command execution failed Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_ola/ola/main.log for details. Error: Follow https://guide.macports.org/#project.tickets to report a bug. Error: Processing of port ola failed
Attachments (1)
Change History (20)
Changed 5 years ago by fdstevex (Steve Tibbett)
comment:1 Changed 5 years ago by fdstevex (Steve Tibbett)
Problem seems to be these build errors:
:info:build protoc/StrUtil.cpp:256:3: error: use of undeclared identifier 'GOOGLE_CHECK' :info:build GOOGLE_CHECK(i >= 0) :info:build ^ :info:build protoc/StrUtil.cpp:436:3: error: use of undeclared identifier 'GOOGLE_DCHECK_LT' :info:build GOOGLE_DCHECK_LT(digits, 100);
comment:2 Changed 5 years ago by jmroot (Joshua Root)
Description: | modified (diff) |
---|---|
Owner: | set to peternewman |
Port: | ola added |
Status: | new → assigned |
Summary: | port install ola +libftdi0 fails → ola @0.10.7 +libftdi0 fails to build |
comment:3 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)
This is an incompatibility with protobuf 3.7 and later. See https://github.com/OpenLightingProject/ola/issues/1550, which has not yet been resolved.
comment:4 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | mlohrey1 added |
---|---|
Summary: | ola @0.10.7 +libftdi0 fails to build → ola @0.10.7 +libftdi0: error: use of undeclared identifier 'GOOGLE_CHECK' |
Has duplicate #59928.
comment:5 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
This problem is still happening.
The upstream issue has been closed. Can we update to a fixed version or backport a fix to our version?
comment:6 Changed 4 years ago by peternewman (Peter Newman)
Hi ryandesign,
For now you can backport the contents of https://github.com/OpenLightingProject/ola/pull/1630/files
Feel free to ignore the Python and Travis changes.
We're trying to get a release out soon, but other stuff keeps breaking us too:
comment:7 Changed 4 years ago by andyggraves
Hi there, I posted a ticked #61374 which was closed as a duplicate and was pointed here. please explain how can i get ola to install? thanks
comment:8 Changed 4 years ago by kencu (Ken)
There are the makings of a fairly simple patch for this issue here <https://github.com/OpenLightingProject/ola/pull/1630/files>, as mentioned in [59585#comment:6]
comment:9 Changed 4 years ago by peternewman (Peter Newman)
Hi Andy,
In the short term you can compile from git. See here: https://www.openlighting.org/ola/mac-install/
In the medium term, someone needs to for now update the package to add the patch I linked to, in the longer term we'll ship a new release which can be switched to and the patches removed.
Unfortunately I won't be able to do this (or at least test it) as our test Mac failed. I could make the changes and someone else could test it, or someone could do all the work. My Mac access is now limited to our Travis setup and whatever CI Macports runs.
I also don't seem to be able to unassign myself.
comment:10 Changed 4 years ago by mf2k (Frank Schima)
Unfortunately I won't be able to do this (or at least test it) as our test Mac failed.
@peternewman: If you submit a GitHub PR, the buildbots will build it for you there.
comment:11 Changed 4 years ago by peternewman (Peter Newman)
Yeah I was more meaning testing the resulting port Frank (or will it at least run our tests?), thanks for the heads up though.
comment:12 Changed 4 years ago by peternewman (Peter Newman)
comment:13 follow-up: 14 Changed 4 years ago by mf2k (Frank Schima)
Yes, it will run the port tests.
comment:14 follow-up: 17 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to mf2k:
@peternewman: If you submit a GitHub PR, the buildbots will build it for you there.
A combination of GitHub Actions, Azure Pipelines, and Travis CI do our PR builds. Buildbot is not involved. Our Buildbot setup only does builds after a commit appears on master.
Replying to mf2k:
Yes, it will run the port tests.
MacPorts does not run tests unless specifically asked to do so via sudo port test
. None of our build infrastructure runs sudo port test
.
comment:15 Changed 4 years ago by Peter Newman <peternewman@…>
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:16 Changed 4 years ago by peternewman (Peter Newman)
Thanks Ryan. Hopefully Andy or Joshua can do that and/or will let us know if it doesn't work generally.
comment:17 Changed 4 years ago by mf2k (Frank Schima)
Replying to ryandesign:
A combination of GitHub Actions, Azure Pipelines, and Travis CI do our PR builds. Buildbot is not involved.
Sorry for the nomenclature mix-up on my end. I did mean the GitHub build process.
None of our build infrastructure runs
sudo port test
.
My bad. I thought that the "Test ports" phase of the Azure pipelines meant running port test
.
comment:18 Changed 4 years ago by andyggraves
Hi there, It does seem to build now, however i am now seeing the following:
andygraves2@AGMBP ola % olad -l 3 dyld: Library not loaded: /opt/local/lib/libmicrohttpd.10.dylib
Referenced from: /usr/local/bin/olad Reason: image not found
zsh: abort olad -l 3
Thanks Andy
comment:19 Changed 4 years ago by peternewman (Peter Newman)
Hi Andy,
That's good news.
I think you'll need to do the equivalent of a make clean. Or a port install may do the trick.
Can you share your build log too if that doesn't work as well as list of installed ports.
First build output