Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#59620 closed defect (fixed)

zstd does need a newer compiler than stock 10.5 supplied

Reported by: rmottola (Riccardo) Owned by: jmroot (Joshua Root)
Priority: Normal Milestone:
Component: ports Version:
Keywords: leopard Cc:
Port: zstd

Description

Compiling zstd on Leopard i386 barfs because it uses gcc-4.2, it is too old.

Just forcing gcc 6 fixed the issue.

Attachments (1)

main.log​ (149.4 KB) - added by rmottola (Riccardo) 5 years ago.
apple gcc-4.2 build log

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)

Please attach a main.log file showing what the problem was.

We don't generally want to recommend the use of MacPorts gcc to solve build issues.

Changed 5 years ago by rmottola (Riccardo)

Attachment: main.log​ added

apple gcc-4.2 build log

comment:2 Changed 5 years ago by jmroot (Joshua Root) 

:info:build cc1: error: unrecognized command line option "-std=c90"

That's an alias for c89 (ANSI adopted the standard in 1989 while ISO adopted it in 1990), should be fine to just patch it to use that instead.

comment:3 Changed 5 years ago by jmroot (Joshua Root)

Owner: set to jmroot
Resolution: → fixed
Status: new → closed

In acabe792eb9212525ffcfe3b4ecbb8b7ce383663/macports-ports (master):

zstd: fix build with older compilers

Closes: #59620

comment:4 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)

Submitted upstream: ​https://github.com/facebook/zstd/pull/1875

comment:5 Changed 5 years ago by rmottola (Riccardo)

I confirm successful build without forcing any compiler (and using standard apple gcc)

Note: See TracTickets for help on using tickets.