Opened 5 years ago

Closed 5 years ago

Last modified 2 years ago

#59695 closed defect (fixed)

port lint should no longer recommend the patch-*.diff naming convention

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: Kurt Hindenburg <kurt.hindenburg@…>
Priority: Normal Milestone: MacPorts 2.7.0
Component: base Version:
Keywords: Cc: kurthindenburg (Kurt Hindenburg)
Port:

Description

The port lint warning about patchfile names should be relaxed. We should no longer recommend/require patchfiles to be named "patch-*.diff". Instead, we should allow any "*.diff" or "*.patch" patchfile name. The lint warning was originally added to discourage users from adding patchfiles that had neither the .diff nor the .patch extension, since that resulted in incorrect syntax coloring in text editors that determine the filetype from the extension.

Change History (4)

comment:1 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Cc: kurthindenburg added

comment:2 Changed 5 years ago by Kurt Hindenburg <kurt.hindenburg@…>

Owner: set to Kurt Hindenburg <kurt.hindenburg@…>
Resolution: fixed
Status: newclosed

In 5037999ebd06309ea216110d17befccc960266cf/macports-base (master):

Adjust lint --niptick on patchfiles to allow *.diff or *.patch (https://github.com/macports/macports-base/pull/170)

The current behavior is to only allow patch-*.diff patchfiles.

Ryan Schmidt's comment on ticket 59695:
The lint warning was originally added to discourage users from adding
patchfiles that had neither the .diff nor the .patch extension, since
that resulted in incorrect syntax coloring in text editors that
determine the filetype from the extension.

closes #59695

comment:3 Changed 4 years ago by jmroot (Joshua Root)

Milestone: MacPorts 2.7.0

comment:4 Changed 2 years ago by jmroot (Joshua Root)

In 67e5cddd9c4a0db39bcc12f96e78c222af98bb78/macports-guide (master):

Correct patchfile naming advice

The only convention we really want to enforce is that patch filenames
end in one of .diff or .patch.

See: #59695

Note: See TracTickets for help on using tickets.