KeePassXC @2.5.1 : compilation failure on macOS 10.11

[tenzap]

Hello, Seems that upstream commit ​7ba9fcc introduced a build failure when compiling macports' KeePassXC 2.5.1

Error is as follows

[ 66%] Building CXX object src/CMakeFiles/keepassx_core.dir/updatecheck/UpdateChecker.cpp.o
cd /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/build/src && /usr/bin/clang++  -DKEEPASSX_BUILDING_CORE -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_MACEXTRAS_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_EXCEPTIONS -DQT_STRICT_ITERATORS -DQT_SVG_LIB -DQT_WIDGETS_LIB -DWITH_APP_BUNDLE -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/build/src/keepassx_core_autogen/include -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/keepassxc-2.5.1-src/src -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/build/src -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/keepassxc-2.5.1-src/src/zxcvbn -isystem /opt/local/include -isystem /opt/local/include/ykpers-1 -iframework /opt/local/libexec/qt5/lib -isystem /opt/local/libexec/qt5/lib/QtCore.framework/Headers -isystem /opt/local/libexec/qt5/./mkspecs/macx-clang -isystem /opt/local/libexec/qt5/lib/QtWidgets.framework/Headers -isystem /opt/local/libexec/qt5/lib/QtGui.framework/Headers -isystem /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenGL.framework/Headers -isystem /opt/local/libexec/qt5/lib/QtConcurrent.framework/Headers -isystem /opt/local/libexec/qt5/lib/QtNetwork.framework/Headers -isystem /opt/local/libexec/qt5/lib/QtSvg.framework/Headers -isystem /opt/local/libexec/qt5/lib/QtMacExtras.framework/Headers  -pipe -Os -DNDEBUG -I/opt/local/include -stdlib=libc++ -fno-common -Wall -Wextra -Wundef -Wpointer-arith -Wno-long-long -Wformat=2 -Wmissing-format-attribute -fvisibility=hidden -fvisibility-inlines-hidden -fstack-protector-strong -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wold-style-cast -Woverloaded-virtual -Werror=format-security -std=c++11  -stdlib=libc++ -arch x86_64 -mmacosx-version-min=10.11   -fPIC -std=gnu++11 -o CMakeFiles/keepassx_core.dir/updatecheck/UpdateChecker.cpp.o -c /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/keepassxc-2.5.1-src/src/updatecheck/UpdateChecker.cpp
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/keepassxc-2.5.1-src/src/gui/macutils/AppKitImpl.mm:26:14: error: unknown type name 'NSEventMask'
static const NSEventMask NSEventMaskKeyDown = NSKeyDownMask;
             ^
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/keepassxc-2.5.1-src/src/gui/macutils/AppKitImpl.mm:26:47: error: use of undeclared identifier 'NSKeyDownMask'
static const NSEventMask NSEventMaskKeyDown = NSKeyDownMask;
                                              ^
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/keepassxc-2.5.1-src/src/gui/macutils/AppKitImpl.mm:142:9: error: unexpected '@' in program
    if (@available(macOS 10.15, *)) {
        ^
3 errors generated.
make[2]: *** [src/CMakeFiles/keepassx_core.dir/gui/macutils/AppKitImpl.mm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/build'
make[1]: *** [src/CMakeFiles/keepassx_core.dir/all] Error 2
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_security_KeePassXC/KeePassXC/work/build'
make: *** [all] Error 2

Details can be found here ​https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/101529/steps/install-port/logs/stdio

[tenzap]

Upstreams ticket closed as "Wontfix" ​https://github.com/keepassxreboot/keepassxc/issues/3932

[yan12125 (Chih-Hsuan Yen)]

Thanks for the report. Could you try if this patched Portfile works on 10.11? ​https://github.com/yan12125/macports-ports/tree/trac-59764/security/KeePassXC

[tenzap]

Compilation is fine on 10.11 and KeePassXC 2.5.1 can be launched without failure.

Thank you.

[Chih-Hsuan Yen <yan12125@…>]

In de1bb703ad19c258ad27eb903cf510dc1930107c/macports-ports (master):

KeePassXC: fix building on 10.11

Thanks tenzap for testing!

Closes: #59764