Opened 5 years ago

Closed 5 years ago

#59823 closed update (fixed)

Update py27-eyed3 to latest version

Reported by: RichieB2B (Richie B2B) Owned by: elelay (Eric Le Lay)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: reneeotten (Renee Otten)
Port: py-eyed3

Description

The latest release is v0.8.11: https://github.com/nicfit/eyeD3/tree/v0.8.11

Attachments (1)

Portfile (2.4 KB) - added by reneeotten (Renee Otten) 5 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 5 years ago by jmroot (Joshua Root)

Owner: set to elelay
Port: py-eyed3 added; py27-eyed3 removed
Status: newassigned

comment:2 Changed 5 years ago by elelay (Eric Le Lay)

Resolution: fixed
Status: assignedclosed

In a2a68f91338917ad4b4c1663e72abc53d4a16448/macports-ports (master):

py-eyed3: upgrade to 0.8.11

Fixes #59823

comment:3 Changed 5 years ago by elelay (Eric Le Lay)

Resolution: fixed
Status: closedreopened

Sorry, but I can't make the updated version to run. It has gained a few deps : pathlib and magic, but even installed it doesn't work. Patch is welcome :-/

Traceback (most recent call last):
  File "/opt/local/bin/eyeD3-2.7", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3251, in <module>
    @_call_aside
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3235, in _call_aside
    f(*args, **kwargs)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3264, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pkg_resources/__init__.py", line 583, in _build_master
    ws.require(__requires__)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'pathlib' distribution was not found and is required by eyeD3

Changed 5 years ago by reneeotten (Renee Otten)

Attachment: Portfile added

comment:5 Changed 5 years ago by reneeotten (Renee Otten)

the attached Portfile should fix this. You likely added py-pathlib2 as a dependency since that is the only port present in MacPorts. One could add a new port for this (really old) package, but pathlib2 should be able to satisfy this requirement as well - so I opted for just replacing pathlib for pathlib2 in the requirements file and source files. In any case based on the GitHub page, upstream will drop support for PY2 in the next release so then all of this can go again.

Other changes I made are listed below:

py-eyed3: update to 0.8.11, switch to PyPI

- add and conform to modeline
- remove unneeded overrides of build.cmd and destroot.cmd
- set correct license
- update homepage
- use pathlib2 instead of pathlib for PY27
- add py37 subport

Please note that I didn't add any of the optional dependencies so you'll get the following message when using it:

eyed3.plugins:WARNING: Plugin '('lastfm.py', '/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/eyed3/plugins')' requires packages that are not installed: No module named pylast

of course, feel free to add these dependencies and add them to the Portfile.

comment:6 Changed 5 years ago by reneeotten (Renee Otten)

Cc: reneeotten added

comment:7 Changed 5 years ago by elelay (Eric Le Lay)

Thanks Renee for the patch. I'll commit as soon a I test the py37 version.

Would you like to adopt the port? I'm retiring from the project, so I'll mark it nomaintainer otherwise.

comment:8 Changed 5 years ago by elelay (Eric Le Lay)

The pathlib2 requirement is still requested at runtime for py37, so I've added it as dependency inconditionnaly.

comment:9 Changed 5 years ago by reneeotten (Renee Otten)

oh, no let's not do that. It's a backport of the pathlib which is present in all newer Python versions. I guess the replacement should only be done for PY27 instead.

comment:10 Changed 5 years ago by reneeotten (Renee Otten)

I'll commit a change for this shortly - I have no interest in maintaining the port though.

comment:11 Changed 5 years ago by elelay (Eric Le Lay)

Good point: Fixed and committed.

comment:12 Changed 5 years ago by elelay (Eric Le Lay)

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.