cmake @3.16.1 fails to build on mavericks

[tehcog (tehcog)]

Please see attached main.log

Dec 10 19:21:59 xxXXXxx === Upgrade Outdated Ports (port -p upgrade --enforce-variants outdated)
Dec 10 19:22:02 xxXXXxx --->  Computing dependencies for cmake
Dec 10 19:22:02 xxXXXxx --->  Fetching archive for cmake
Dec 10 19:22:05 xxXXXxx --->  Attempting to fetch cmake-3.16.1_0.darwin_13.x86_64.tbz2 from https://packages.macports.org/cmake
Dec 10 19:22:06 xxXXXxx --->  Attempting to fetch cmake-3.16.1_0.darwin_13.x86_64.tbz2 from http://ywg.ca.packages.macports.org/mirror/macports/packages/cmake
Dec 10 19:22:07 xxXXXxx --->  Attempting to fetch cmake-3.16.1_0.darwin_13.x86_64.tbz2 from http://aus.us.packages.macports.org/macports/packages/cmake
Dec 10 19:22:08 xxXXXxx --->  Verifying checksums for cmake
Dec 10 19:22:08 xxXXXxx --->  Extracting cmake
Dec 10 19:22:10 xxXXXxx --->  Applying patches to cmake
Dec 10 19:22:10 xxXXXxx --->  Configuring cmake
Dec 10 19:22:53 xxXXXxx --->  Building cmake
Dec 10 19:24:01 xxXXXxx Error: Failed to build cmake: command execution failed
Dec 10 19:24:01 xxXXXxx Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cmake/cmake/main.log for details.

[tehcog (tehcog)]

main.log

[michaelld (Michael Dickens)]

Actual error is:

cmake-3.16.1/Tests/CMakeLib/testCTestResourceSpec.cxx:14:40: error: no matching constructor for initialization of 'const std::vector<ExpectedSpec>'
:info:build static const std::vector<ExpectedSpec> expectedResourceSpecs = {
:info:build                                        ^                       ~
:info:build /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/vector:527:9: note: candidate constructor template not viable: requires 2 arguments, but 37 were provided
:info:build         vector(_InputIterator __first,
:info:build         ^

[michaelld (Michael Dickens)]

@kencu : we closed #59782 already as fixed ... this error looks to be exactly the same ... but clearly it is for CMake 3.16.1 that I pushed today. Any ideas?

[michaelld (Michael Dickens)]

Maybe this is a duplicate of #59822 .. just for Mavericks rather than Mountain Lion ?

[kencu (Ken)]

Yes indeed -- that vector code is messing up older clang versions. This is getting rather irritating! Perhaps someone upstream knows how to fix it -- I tried Josh's fix idea in #59822 but that didn't work. Then I spent an hour trying all kinds of things (rather stupidly and randomly) and none of them worked either.

I believe it's the default initializer in that vector template that is not working right.