libde265 @1.0.3 does not build on PPC Tiger because 'memalign' was not declared in this scope

[ballapete (Peter "Pete" Dyballa)]

/bin/sh ../libtool  --tag=CXX   --mode=compile /opt/local/bin/g++-mp-7 -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include  -DLIBDE265_EXPORTS  -pipe -Os -D_GLIBCXX_USE_CXX11_ABI=0 -arch ppc -Werror=return-ty\
pe -Werror=unused-result -Werror=reorder -DDE265_LOG_ERROR -MT libde265_la-image.lo -MD -MP -MF .deps/libde265_la-image.Tpo -c -o libde265_la-image.lo `test -f 'image.cc' || echo './'`image.cc
libtool: compile:  /opt/local/bin/g++-mp-7 -DHAVE_CONFIG_H -I. -I.. -I/opt/local/include -DLIBDE265_EXPORTS -pipe -Os -D_GLIBCXX_USE_CXX11_ABI=0 -arch ppc -Werror=return-type -Werror=unused-result -Werror\
=reorder -DDE265_LOG_ERROR -MT libde265_la-image.lo -MD -MP -MF .deps/libde265_la-image.Tpo -c image.cc  -fno-common -DPIC -o .libs/libde265_la-image.o
image.cc: In function 'void* de265_alloc_image_plane(de265_image*, int, void*, int, void*)':
image.cc:60:45: error: 'memalign' was not declared in this scope
 #define ALLOC_ALIGNED(alignment, size)      memalign((alignment), (size))
                                             ^
image.cc:64:45: note: in expansion of macro 'ALLOC_ALIGNED'
 #define ALLOC_ALIGNED_16(size)              ALLOC_ALIGNED(16, size)
                                             ^~~~~~~~~~~~~
image.cc:75:27: note: in expansion of macro 'ALLOC_ALIGNED_16'
   uint8_t* p = (uint8_t *)ALLOC_ALIGNED_16(stride * height + MEMORY_PADDING);
                           ^~~~~~~~~~~~~~~~
image.cc: In function 'int de265_image_get_buffer(de265_decoder_context*, de265_image_spec*, de265_image*, void*)':
image.cc:60:45: error: 'memalign' was not declared in this scope
 #define ALLOC_ALIGNED(alignment, size)      memalign((alignment), (size))
                                             ^
image.cc:64:45: note: in expansion of macro 'ALLOC_ALIGNED'
 #define ALLOC_ALIGNED_16(size)              ALLOC_ALIGNED(16, size)
                                             ^~~~~~~~~~~~~
image.cc:127:21: note: in expansion of macro 'ALLOC_ALIGNED_16'
   p[0] = (uint8_t *)ALLOC_ALIGNED_16(luma_height   * luma_bpl   + MEMORY_PADDING);
                     ^~~~~~~~~~~~~~~~
make[3]: *** [libde265_la-image.lo] Error 1
make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_multimedia_libde265/libde265/work/libde265-1.0.3/libde265'

Which port needs libde265?

[ballapete (Peter "Pete" Dyballa)]

Main.log from PPC Tiger

[ballapete (Peter "Pete" Dyballa)]

The same happens on PPC Leopard, Mac OS X 10.5.8.

[kencu (Ken)]

Using the legacysupport PG fixes this. Perhaps Marcus would find this acceptable.

[kencu (Ken)]

legacysupport provides a not-bad implementation of posix_memalign, that satisfies this software. If you stressed it heavily with memory requests >16 bytes but <4K, you would find warts, tho.

To really fill that need, there are some memory allocation implementations that can be used, but these require changing source code (or at the least, some fancy #define artistry.

[ballapete (Peter "Pete" Dyballa)]

Replying to kencu:

Using the legacysupport PG fixes this.

Indeed! This allowed to build on PPC Leopard.

[kencu (Ken)]

I fixed the other similar port with this issue, but this one belongs to Marcus.

[ballapete (Peter "Pete" Dyballa)]

The same error happens with libde265 @1.0.5.

[ballapete (Peter "Pete" Dyballa)]

The cure is still

PortGroup                   legacysupport 1.0

in Portfile.

[xanda-escuyer (xanda)]

Replying to ballapete:

Replying to kencu:

Using the legacysupport PG fixes this.

Indeed! This allowed to build on PPC Leopard.

We have legacy-support 0.11.1_0 installed/active but libde265 @1.0.5 still won't build; failing with same error.

Are we missing something out?

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

Has duplicate #60276.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

In 91e1dd23a2fb703e638604fb1769faaad8d92e3e/macports-ports (master):

libde265: allow build on older systems

Fixes #59866