Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#59970 closed defect (fixed)

build failure: port -vd install vigra +debug +docs +python37 +valgrind

Reported by: TheLastLovemark Owned by: BSeppke (Benjamin Seppke)
Priority: Normal Milestone:
Component: ports Version: 2.6.2
Keywords: Cc:
Port: vigra

Description

log file attached.

from the errors I saw, it looks like the std namespace was overused

Attachments (2)

vigra_main.log (221.8 KB) - added by TheLastLovemark 5 years ago.
patch-sifImprt.diff (457 bytes) - added by BSeppke (Benjamin Seppke) 5 years ago.
Hopefully, this should fix it…

Download all attachments as: .zip

Change History (12)

Changed 5 years ago by TheLastLovemark

Attachment: vigra_main.log added

comment:1 Changed 5 years ago by mf2k (Frank Schima)

Cc: BSeppke removed
Owner: set to BSeppke
Status: newassigned

comment:2 Changed 5 years ago by BSeppke (Benjamin Seppke)

Thanks for the report - you seem about to be the first one installing a debug version ;)

Changed 5 years ago by BSeppke (Benjamin Seppke)

Attachment: patch-sifImprt.diff added

Hopefully, this should fix it...

comment:3 Changed 5 years ago by BSeppke (Benjamin Seppke)

Created fix and queued pull request on GitHub:

comment:4 in reply to:  3 Changed 5 years ago by TheLastLovemark

Replying to BSeppke:

Created fix and queued pull request on GitHub:

What do I need to do to get the port to build? Is it simply a matter of waiting until BSeppke gives me the OKay?

comment:5 Changed 5 years ago by kencu (Ken)

every test build failed, so it's going to be hard to commit that PR until that is sorted out.

Looks like vigra has a clean-sweep of build failures at present <https://ports.macports.org/port/vigra/builds>

comment:6 in reply to:  5 Changed 5 years ago by TheLastLovemark

Replying to kencu:

every test build failed, so it's going to be hard to commit that PR until that is sorted out.

Looks like vigra has a clean-sweep of build failures at present <https://ports.macports.org/port/vigra/builds>

That sucks. But on the bright side, it's good to know that it's not just me.

comment:7 Changed 5 years ago by BSeppke (Benjamin Seppke)

Hi all,

the PR is okay as is - it should be merged anyways. The non-running tests are (as far as I see) due to the complex dependency structure of vigra. If you install the default setting, which is currently set to +python27 dependency, you must have installed boost with exactly that variant to have boost_python installed for python27 as well. AFAIK, this makes the tests fail for the buildbot.

comment:8 Changed 5 years ago by BSeppke (Benjamin Seppke)

Resolution: fixed
Status: assignedclosed

In fe07317ec0ea851d25cc66176aa943c02e3a818d/macports-ports (master):

vigra: provide patch for using in debug variant.

Closes: #59970

comment:9 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)

When you add a patch to a portfile, it is a good idea to provide a reference to the upstream bug report and the commit from which the patch was taken. I usually put such information at the top of the patchfile. In this case, they are:

https://github.com/ukoethe/vigra/issues/424
https://github.com/ukoethe/vigra/commit/ae471de24b083bda05eb0cc798e2aede32d09e27

Given how long ago those were, it is sad that the developers have not released a new version with those changes.

comment:10 Changed 4 years ago by BSeppke (Benjamin Seppke)

In fe07317ec0ea851d25cc66176aa943c02e3a818d/macports-ports (dar, master, py38-reproject, revert-6945-rust-1.43.0, wireshark):

vigra: provide patch for using in debug variant.

Closes: #59970

Note: See TracTickets for help on using tickets.