libmypaint @1.5.1_0: upgrade fails on configure with "error: XML::Parser perl module is required for intltool" (regression)

[JDLH (Jim DeLaHunt)]

When I do port upgrade libmypaint to bring libmypaint @1.5.0_0 to @1.5.1_0, the configuration fails in exactly the same way as #58012:

% port installed libmypaint perl5 
The following ports are currently installed:
  libmypaint @1.4.0_1
  libmypaint @1.5.0_0 (active)
  perl5 @5.26.1_0+perl5_26 (active)
  perl5 @5.26.1_0+perl5_28
% sudo port upgrade libmypaint
--->  Computing dependencies for libmypaint
--->  Fetching archive for libmypaint
--->  Attempting to fetch libmypaint-1.5.1_0.darwin_17.x86_64.tbz2 from https://packages.macports.org/libmypaint
--->  Attempting to fetch libmypaint-1.5.1_0.darwin_17.x86_64.tbz2 from https://ywg.ca.packages.macports.org/mirror/macports/packages/libmypaint
--->  Attempting to fetch libmypaint-1.5.1_0.darwin_17.x86_64.tbz2 from http://aus.us.packages.macports.org/macports/packages/libmypaint
--->  Fetching distfiles for libmypaint
--->  Verifying checksums for libmypaint
--->  Extracting libmypaint
--->  Configuring libmypaint
Error: Failed to configure libmypaint, consult /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_libmypaint/libmypaint/work/libmypaint-1.5.1/config.log
Error: Failed to configure libmypaint: configure failure: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_libmypaint/libmypaint/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.

I'm attaching …libmypaint/main.log and …libmypaint/work/libmypaint-1.5.1/config.log, but the punchline appears to be this, in main.log:

:info:configure checking for perl >= 5.8.1... 5.26.3
:info:configure checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool

Just as in #58012, tweaking the Perl5 variant is an effective workaround.

% sudo port upgrade --enforce-variants perl5 -perl5_26 +perl5_28

However, #58012 was fixed by including code in the Portfile to "reconfigure with our intltool.m4 using upstream autogen.sh" (see changeset:0fe1ca9a3b956f9e0e3d61c233ae3b868022ccfb/macports-ports). That code is still in the Portfile, yet the regression occurred.

The Portfile was changed on 24 Feb 2020 (just yesterday) to upgrade libmypaint from 1.5.0 to 1.5.1. See changeset:438b73a9b9b1433e9a7661d279fb73643ad53254/macports-ports.

[JDLH (Jim DeLaHunt)]

/opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_libmypaint/libmypaint/main.log

[JDLH (Jim DeLaHunt)]

/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_libmypaint/libmypaint/work/libmypaint-1.5.1/config.log

[ryandesign (Ryan Carsten Schmidt)]

Replying to JDLH:

:info:configure checking for perl >= 5.8.1... 5.26.3
:info:configure checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool

This appears to be a new problem in 1.5.1. I am able to reproduce the problem in 1.5.1 (by installing perl5 +perl5_26), but not in 1.5.0.

Just as in #58012, tweaking the Perl5 variant is an effective workaround.

% sudo port upgrade --enforce-variants perl5 -perl5_26 +perl5_28

Certainly, but you should not need to do that.

However, #58012 was fixed by including code in the Portfile to "reconfigure with our intltool.m4 using upstream autogen.sh" (see changeset:0fe1ca9a3b956f9e0e3d61c233ae3b868022ccfb/macports-ports). That code is still in the Portfile, yet the regression occurred.

The Portfile was changed on 24 Feb 2020 (just yesterday) to upgrade libmypaint from 1.5.0 to 1.5.1. See changeset:438b73a9b9b1433e9a7661d279fb73643ad53254/macports-ports.

In 1.5.1, they started bundling a copy of intltool.m4, thus defeating the fact that we have an improved intltool.m4 in our intltool port. So we either need to patch the bundled intltool.m4 or else maybe just delete it so that the one from the intltool port gets used.

[ryandesign (Ryan Carsten Schmidt)]

In 76a14cf9f6751c0f085a639cd616c5a51b150bee/macports-ports (master):

libmypaint: Add patch from intltool port

Fixes build failure when the installed variant of the perl5 port does
not match what the intltool port uses.

Closes: #60130

[JDLH (Jim DeLaHunt)]

Thank you, Ryan! I was able to upgrade to libmypaint from @1.5.0_0 to @1.5.1_0 with the fixed version. I agree that this bug is fixed (for my situation, at least).