#60518 closed defect (invalid)
mpv 0.32.0
Reported by: | dardo82 (Michele Venturi) | Owned by: | Ionic (Mihai Moldovan) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.6.2 |
Keywords: | highsierra | Cc: | dardo82 (Michele Venturi), mrkapqa |
Port: | mpv |
Description (last modified by mf2k (Frank Schima))
0.32.0 doesn't work with --disable-swift
https://github.com/mpv-player/mpv/issues/7449
"cocoa-cb backend requires Swift 5 or 4 support, which is only available in Xcode 9.1 onwards."
No, Command Line Tools will suffice; it works commenting out the subsequent conditional statement.
changeset:968496de4d39c0a8c65e3a306e14e6886827ac2a/macports-ports
Configuration: ./waf configure --prefix=/opt/local --enable-manpage-build --enable-libass --enable-coreaudio --enable-cocoa --enable-cplugins --enable-zlib --enable-swift --disable-html-build --disable-cuda-hwaccel --disable-opensles --disable-egl-drm --disable-egl-angle-lib --disable-egl-angle-win32 --disable-audiounit --disable-ios-gl --disable-direct3d --disable-android --disable-rpi --disable-dvbin --disable-pdf-build --disable-test --disable-clang-database --disable-debug-build --disable-libsmbclient --enable-dvdnav --enable-cdda --disable-vapoursynth --enable-libarchive --enable-rubberband --disable-pulse --disable-jack --disable-openal --enable-gl-cocoa --disable-x11 --disable-xv --disable-gl-x11 --disable-egl-x11 --disable-caca --disable-jpeg --disable-tv --enable-gl --disable-javascript --disable-uchardet --enable-videotoolbox-gl --enable-lua --lua=52fbsd --enable-libass-osd
[cplayer] List of enabled features: 52fbsd asm atomics bsd-fstatfs build-date cdda cocoa coreaudio cplayer cplugins drmprime dvdnav fchmod ffmpeg gl gl-cocoa glob glob-posix gnuc gpl iconv lcms2 libarchive libass libass-osd libav-any libavcodec libavdevice libavutil libbluray libdl libm lua macos-10-11-features macos-10-12-2-features macos-10-14-features macos-cocoa-cb macos-media-player macos-touchbar optimize osx-thread-name posix posix-or-mingw posix-spawn posix-spawn-native pthreads rubberband stdatomic videotoolbox-gl videotoolbox-hwaccel zlib
Attachments (1)
Change History (24)
Changed 4 years ago by dardo82 (Michele Venturi)
comment:1 Changed 4 years ago by mf2k (Frank Schima)
In the future, please use WikiFormatting and add the port maintainer(s) to Cc (port info --maintainers mpv
), if any.
comment:2 Changed 4 years ago by mf2k (Frank Schima)
Also, the Milestone field is for use by Macports team members only, please do not set it.
comment:3 Changed 4 years ago by mf2k (Frank Schima)
Milestone: | MacPorts 2.6.3 |
---|---|
Owner: | set to Ionic |
Status: | new → assigned |
comment:4 Changed 4 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
comment:5 Changed 4 years ago by mf2k (Frank Schima)
Thanks for the suggested fix. Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. Or better yet, submit a GitHub pull request.
comment:6 Changed 4 years ago by kencu (Ken)
Or just wait a bit -- there are multiple floating tickets about mpv, and I've nearly got it done:
<https://github.com/kencu/macports-ports/commits/mpvoldersystemsfix>
comment:7 follow-ups: 8 11 17 Changed 4 years ago by dardo82 (Michele Venturi)
Thanks for the quick reply, couldn't wait as it stopped working as stated but can I install it from your branch
comment:9 follow-up: 10 Changed 4 years ago by kencu (Ken)
Here is a PR that fixes the mpv build on 10.7 to 10.10; 10.11+ seem fine at present.
<https://github.com/macports/macports-ports/pull/7153>
I'll take a look at 10.4 to 10.6 later on.
comment:10 Changed 4 years ago by dardo82 (Michele Venturi)
Replying to kencu:
Here is a PR that fixes the mpv build on 10.7 to 10.10; 10.11+ seem fine at present.
<https://github.com/macports/macports-ports/pull/7153>
I'll take a look at 10.4 to 10.6 later on.
HAVE YOU EVEN TRIED TO USE IT ON 10.13?
HAVE YOU READ WHAT I'VE WRITTEN?
I'M I WASTING MY TIME?
It builds but doesn't work!
This is exactly why I don't wait:
you can't trust people
with making their job right.
And you are not going to get much help
disregarding whatn newcomers tells you!
comment:12 follow-up: 13 Changed 4 years ago by dardo82 (Michele Venturi)
That is actually a good decision, you don't seem up for the task.
comment:13 Changed 4 years ago by neverpanic (Clemens Lang)
Replying to dardo82:
HAVE YOU EVEN TRIED TO USE IT ON 10.13?
HAVE YOU READ WHAT I'VE WRITTEN?
I'M I WASTING MY TIME?
It builds but doesn't work!This is exactly why I don't wait:
you can't trust people
with making their job right.And you are not going to get much help
disregarding whatn newcomers tells you!
Replying to dardo82:
That is actually a good decision, you don't seem up for the task.
Regardless of whether this is technically correct or not, this attitude is uncalled for in a project where people invest their free time.
Please refrain from such insults in the future.
comment:14 Changed 4 years ago by neverpanic (Clemens Lang)
Also to be honest, from your ticket description, I can't figure out what you actually want to do (I guess I'm "not up for the task" either…), you didn't attach a unified diff like you were asked to in comment:5, and you don't seem to have opened a pull request either.
comment:15 Changed 4 years ago by kencu (Ken)
Although I also found this ticket indecipherable, the upstream issue links to an upstream bug that has been fixed here in this commit <https://github.com/mpv-player/mpv/commit/188169854313b99d01da8f69fe129f0a487eb7c4>.
So feel free to help this fellow out -- as I am just not up to the task.
comment:16 Changed 4 years ago by dardo82 (Michele Venturi)
I just wanted to help, but you aren't interested, then stop pretending you are the managers of the project and go spend your precious free time somewhere else...
P.S. It seems I was right about it being broken, unlike what you said.
comment:17 Changed 4 years ago by kencu (Ken)
Replying to dardo82:
Furthermore this nearly the first time I try to do this,I'm not yet familiar with the best practices
You're certainly making quite a splash with your entrance.
comment:18 Changed 4 years ago by tobypeterson
Resolution: | → invalid |
---|---|
Status: | assigned → closed |
As noted in other comments, best practice is to submit either a patch (unified diff format) or a PR on github.
Closing this ticket; if you'd like to try again, please attempt to be civil next time.
comment:20 Changed 4 years ago by mrkapqa
Hello ,
I have similar problem on a fresh install of Mac OS Sierra
Mpv builds, but won't start with error
Title: No Equality Assertion failed: (group_index >= 0), function m_config_cache_alloc_internal, file ../options/m_config.c, line 1461. Abort trap: 6
I have latest Xcode for Sierra (9.2) installed.
do I just need to re-run "sudo port install mpv" and somehow enable this cocoa-cb?
comment:21 Changed 4 years ago by mrkapqa
my bad,
I had only the command line tools properly installed at the time of installing mpv port; after uninstalling and re-installing all port with Xcode 9.2 activated the mpv port installs and functions as desired. Thank you.
comment:22 Changed 4 years ago by mrkapqa
Cc: | mrkapqa added |
---|
comment:23 Changed 4 years ago by mrkapqa
However, I noticed that the mpv build would fail to configure if python27 is not activated prior (and this not only on Sierra, also HighSierra probably and onwards)
Attempting to fetch mpv-0.32.0_1+audiocd+bluray+bundle+dvd+libarchive+network+opengl+osd+python38+rubberband.darwin_16.x86_64.tbz2 from https://nue.de.packages.macports.org/mpv ... Configuring mpv Error: Failed to configure mpv: configure failure: command execution failed
sudo port install python27 mpv
fixes it, but probably there should be another fix?
fixed port file