Opened 4 years ago

Closed 4 years ago

#60519 closed update (fixed)

fish: update to latest version

Reported by: szhorvat (Szabolcs Horvát) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: fish

Description

This is a request to update fish to the latest version, 3.1.2

I tried to do it myself. Other than bumping the version and updating the checksum, the patch-src-expand-sys-time.diff patch should be removed as upstream already has it. However, after doing these changes, the tests fail, like this:

:info:test Scanning dependencies of target serial_test_low_level
:info:test /Library/Developer/CommandLineTools/usr/bin/make  -f CMakeFiles/serial_test_low_level.dir/build.make CMakeFiles/serial_test_low_level.dir/build
:info:test env XDG_DATA_HOME=test/data XDG_CONFIG_HOME=test/home ./fish_tests
:info:test dyld: Library not loaded: /opt/local/lib/libncurses.6.dylib
:info:test   Referenced from: /opt/local/var/macports/build/_Users_szhorvat_ports_shells_fish/fish/work/build/./fish_tests
:info:test   Reason: no suitable image found.  Did find:
:info:test 	/opt/local/lib/libncurses.6.dylib: code signature in (/opt/local/lib/libncurses.6.dylib) not valid for use in process using Library Validation: mapped file has no cdhash, completely unsigned? Code has to be at least ad-hoc signed.
:info:test 	/opt/local/lib/libncurses.6.dylib: stat() failed with errno=1
:info:test make[3]: *** [CMakeFiles/serial_test_low_level] Abort trap: 6
:info:test make[2]: *** [CMakeFiles/serial_test_low_level.dir/all] Error 2
:info:test make[1]: *** [CMakeFiles/test.dir/rule] Error 2
:info:test make: *** [test] Error 2
:info:test Command failed:  cd "/opt/local/var/macports/build/_Users_szhorvat_ports_shells_fish/fish/work/build" && /usr/bin/make test 
:info:test Exit code: 2
:error:test Failed to test fish: command execution failed

This is beyond my knowledge. Note: I am on 10.14.6, not on 10.15. This was using Xcode 11.3.1.

Change History (4)

comment:1 Changed 4 years ago by szhorvat (Szabolcs Horvát)

comment:2 Changed 4 years ago by jmroot (Joshua Root)

It appears to be using the hardened runtime, which won't work unless all libraries used are signed.

comment:3 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Summary: Update fish to latest versionfish: update to latest version
Type: requestupdate

comment:4 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: set to ryandesign
Resolution: fixed
Status: newclosed

In b2d4ca110c96d624e679eb862d0f96b417e941ba/macports-ports (master):

fish: Update to 3.1.2

Closes: #60519

Note: See TracTickets for help on using tickets.