Opened 4 years ago

Closed 4 years ago

#60551 closed defect (fixed)

db-browser-for-sqlite installs a symlink at post-activate

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: i0ntempest
Priority: Normal Milestone:
Component: ports Version: 2.6.2
Keywords: Cc:
Port: db-browser-for-sqlite

Description

db-browser-for-sqlite creates a symlink in a post-activate block and removes it in a post-deactivate block:

post-activate {
        ln -s "${applications_dir}/DB Browser for SQLite.app/Contents/MacOS/DB Browser for SQLite" ${prefix}/bin/sqlitebrowser
}
post-deactivate {
        delete ${prefix}/bin/sqlitebrowser
}

Why not create it in post-destroot so that it is registered to the port? Then MacPorts will automatically install it at activate time and remove it at deactivate time along with all the port's other files.

post-destroot {
    ln -s "${applications_dir}/DB Browser for SQLite.app/Contents/MacOS/DB Browser for SQLite" ${destroot}${prefix}/bin/sqlitebrowser
}

Change History (3)

comment:1 Changed 4 years ago by i0ntempest

Good point. Changing it now

comment:2 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks! When you do, remember to increase the revision.

comment:3 Changed 4 years ago by i0ntempest

Resolution: fixed
Status: assignedclosed

In 53ebefaaf394f5abe6e3e4d2b28590aaf3714d33/macports-ports (master):

db-browser-for-sqlite: move symlink creation into post-destroot

Closes: #60551

Note: See TracTickets for help on using tickets.