osquery @4.3.0: error: use of undeclared identifier '_SC_PHYS_PAGES'

[ryandesign (Ryan Carsten Schmidt)]

​osquery does not build on OS X 10.10 and earlier:

.../osquery-4.3.0/libraries/cmake/source/lzma/src/src/common/tuklib_physmem.c:146:29: error: use of undeclared identifier '_SC_PHYS_PAGES'
        const long pages = sysconf(_SC_PHYS_PAGES);
                                   ^
1 error generated.

​Here is how this problem was fixed in another port.

However it looks like the error is being encountered when building a bundled third-party lzma library. If that's true, see if you can convince osquery to use a MacPorts-provided copy of that and any other bundled libraries instead. Then we can fix this problem (if it still exists) in those ports and then everyone benefits, not just osquery.

[kencu (Ken)]

I added this fix generally to legacysupport.

[kencu (Ken)]

<​https://github.com/macports/macports-legacy-support/blob/170f17c6b08ea67532f25e399749ff29e1fbc678/src/macports_legacy_sysconf.c#L76>

[ryandesign (Ryan Carsten Schmidt)]

That's great; thank you. Nevertheless please check the last paragraph of the ticket description before going with the legacysupport solution.