pihpsdr: error: field has incomplete type 'struct sockaddr'

[ryandesign (Ryan Carsten Schmidt)]

​pihpsdr doesn't build on Mountain Lion or earlier:

In file included from stemlab_discovery.c:34:
/usr/include/net/if.h:306:19: error: field has incomplete type 'struct sockaddr'
                struct  sockaddr ifru_addr;
                                 ^
/usr/include/ifaddrs.h:37:9: note: forward declaration of 'struct sockaddr'
        struct sockaddr *ifa_addr;
               ^

Maybe a required header hasn't been included.

[kencu (Ken)]

looks like exactly the same issue as <​https://github.com/macports/macports-ports/pull/7350#issuecomment-640948200>

maybe I'll just add that missing header in legacysupport and fix all these at once, as I so like to do :)

[ryandesign (Ryan Carsten Schmidt)]

As usual, it's a tradeoff between helping upstream developers fix their software so that it compiles on a wider range of unmodified systems vs. using something quick and easy to get things working in MacPorts while neglecting non-MacPorts users and the upstream developers.

[kencu (Ken)]

Nobody except MacPorts supports < 10.9 any more.

Edit - well that's a broad statement. Some might. It doesn't do MacPorts a disservice to be known as the place to go if you want this to work though.

[ryandesign (Ryan Carsten Schmidt)]

Yes, that statement is broad. While I agree that many developers do not care about older systems, others do. In addition, it seems possible that the same issue might affect other operating systems that the developers would care about. To reuse your word, it does a disservice to upstream developers to assume that they are not interested in fixing bugs in their software and to not even report problems to them. It has the effect of turning us into developers of their software, which is not really what we want to be.

[kencu (Ken)]

We see this "older system support" issue from a 180 degrees different perspective, obviously.

There is room for both approaches.

[Davide Gerhard <ra1nb0w@…>]

In 81c98aac97b7bc21722dd54337ef4d3e8fb40ee0/macports-ports (master):

pihpsdr: update commit to 49fbd961

temporary patch are now upstream

Closes: #60652