v2ray overrides the build phase

[ryandesign (Ryan Carsten Schmidt)]

The v2ray portfile overrides the build phase. It seems like this would bypass some desirable aspects of the golang 1.0 portgroup, such as properly setting the CC and GOARCH environment variables. Can it use the build phase normally instead of overriding it?

[i0ntempest]

v2ray port needs to build 2 binaries using different options, can macports do this without overriding the build phase?

[ryandesign (Ryan Carsten Schmidt)]

I see... I am not familiar with how go software is normally built but it would be hard for me to believe that the go build system can't accommodate this.

[i0ntempest]

Unfortunately I'm not either. I'll try if adding build args can do this, if not maybe the go portgroup needs to be changed to allow this.

[ryandesign (Ryan Carsten Schmidt)]

Well the port currently does this:

build {
    system -W ${worksrcpath}/main "env CGO_ENABLED=0 go build -o ./v2ray -ldflags \"-s -w\""
    system -W ${worksrcpath}/infra/control/main "env CGO_ENABLED=0 go build -o ./v2ctl -tags confonly -ldflags \"-s -w\""
}

Is there some v2ray documentation that said to do that?

[i0ntempest]

Yes, this is the official compile guide: ​https://www.v2ray.com/developer/intro/compile.html

[casouri (Yuan Fu)]

unfortunately, I don't know enough Go to make changes to the build command. Maybe someone else with that knowledge can. I'd be happy to change the portfile accordingly.

[ryandesign (Ryan Carsten Schmidt)]

Yeah it's probably something that needs to be taken to the developers of v2ray. They should provide a single command that can build everything. (Just like in a project that use make correctly you would run make all or just make and it would make everything; you don't have to run multiple make commands in separate directories.)

[i0ntempest]

In b6057febb7c91aac123c9a08ea8f64cc068aa9be/macports-ports (master):

v2ray: update to 4.31.0 & migrate to the new repo & ... (​https://github.com/macports/macports-ports/pull/8721)

vendor go dependencies & use full build.env, proper build.cmd
Closes: #60682