libaacs: error: implicit declaration of function is invalid in C99

[dyne2meter]

:info:build src/examples/aacs_info.c:122:33: error: implicit declaration of function 'aacs_get_bdj_root_cert_hash' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build     const uint8_t *bdj_hash   = aacs_get_bdj_root_cert_hash(aacs);
:info:build                                 ^
:info:build src/examples/aacs_info.c:122:20: warning: incompatible integer to pointer conversion initializing 'const uint8_t *' (aka 'const unsigned char *') with an expression of type 'int' [-Wint-conversion]
:info:build     const uint8_t *bdj_hash   = aacs_get_bdj_root_cert_hash(aacs);
:info:build                    ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build src/examples/aacs_info.c:123:33: error: implicit declaration of function 'aacs_get_content_cert_id' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build     const uint8_t *cc_id      = aacs_get_content_cert_id(aacs);
:info:build                                 ^
:info:build src/examples/aacs_info.c:123:20: warning: incompatible integer to pointer conversion initializing 'const uint8_t *' (aka 'const unsigned char *') with an expression of type 'int' [-Wint-conversion]
:info:build     const uint8_t *cc_id      = aacs_get_content_cert_id(aacs);
:info:build                    ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build 2 warnings and 2 errors generated.

[dyne2meter]

main.log

[ryandesign (Ryan Carsten Schmidt)]

It probably shouldn't be using -Werror.

[ryandesign (Ryan Carsten Schmidt)]

But it built successfully on many macOS versions on our buildbot. The 10.11 builder was temporarily offline so it hadn't built this yet, but it's back online now. We should check if it builds this port without error, and if so, we should compare its log with the one attached to this ticket to see what's different.

[dyne2meter]

It won't differ, at least not by much. This build failure was on 10.11

[i0ntempest]

Do you by chance have the previous version of the library active? If yes maybe deactivate it and try again, I noticed this when trying to upgrade from 0.9 to 0.10

[jmroot (Joshua Root)]

If that works, it would indicate incorrect ordering of include flags.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign:

We should check if it builds this port without error, and if so, we should compare its log with the one attached to this ticket to see what's different.

Successful build on buildbot:

​https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/117016

Looking at the diff between the logs isn't very helpful because the port didn't disable silent build rules. I've fixed that now.

Replying to i0ntempest:

Do you by chance have the previous version of the library active? If yes maybe deactivate it and try again, I noticed this when trying to upgrade from 0.9 to 0.10

Yes, I can confirm that I see that problem on my macOS 10.13 system with libaacs @0.8.1 installed.

[ryandesign (Ryan Carsten Schmidt)]

In ef39340413dd948928012923c56bb1265477d37d/macports-ports (master):

libaacs: Use -isystem instead of -I

Works around incorrect order of flags and fixes a potential build
failure when a previous version of the port is installed.

Closes: #60782

[jmroot (Joshua Root)]

In 76973121d7f85a25c850223b7736ced12f5c5aa5/macports-ports (master):

libaacs: fix incorrect include ordering

Fixes: #60782

[jmroot (Joshua Root)]

​https://code.videolan.org/videolan/libaacs/-/merge_requests/9