BUG: tsocks-1.8beta5_1 aborts with "Socket is already connected"

[darren.bane@…]

the error log can be found here: INLINE

Description: The above errno value obviously didn't arise on tsocks's original platform, but does on Darwin. And it shouldn't be treated as a catastrophic error.

Comments: This was previously reported as ​https://sourceforge.net/tracker/index.php? func=detail&aid=1252703&group_id=17338&atid=117338 I reviewed the patch attached to that bug (including the first followup) and it seems sensible for Darwin as well as NetBSD. I'm also running it successfully in my local ports tree.

================INLINE CONTENT================ % mixminion flush Mixminion version 0.0.7.1 This software is for testing purposes only. Anonymity is not guaranteed. Dec 14 18:33:20.612 +0000 [INFO] Flushing packet queue Dec 14 18:33:20.627 +0000 [INFO] Found 1 pending packets Dec 14 18:33:20.632 +0000 [INFO] Sending 1 packets to server at nowwhat.lateralis.org:48100... Dec 14 18:33:20.634 +0000 [INFO] Connecting... 18:33:20 libtsocks(22539): Got connection request 18:33:20 libtsocks(22539): Connection isn't a TCP stream ignoring 18:33:20 libtsocks(22539): Call to close(3) 18:33:20 libtsocks(22539): Got connection request 18:33:20 libtsocks(22539): Connection isn't a TCP stream ignoring 18:33:20 libtsocks(22539): Call to close(3) 18:33:20 libtsocks(22539): Got connection request 18:33:20 libtsocks(22539): New network entry for 10.0.0.0 going to 0x00649250 18:33:20 libtsocks(22539): Call to close(5) 18:33:20 libtsocks(22539): New network entry for 127.0.0.0 going to 0x00649270 18:33:20 libtsocks(22539): Got connection request for socket 3 to 81.56.190.81 18:33:20 libtsocks(22539): Picking appropriate server for 81.56.190.81 18:33:20 libtsocks(22539): Picked server staff-proxy.ul.ie for connection 18:33:20 libtsocks(22539): Beginning handle loop for socket 3 18:33:20 libtsocks(22539): In request handle loop for socket 3, current state of request is 0 18:33:20 libtsocks(22539): Connecting to 10.220.1.19 port 1080 18:33:20 libtsocks(22539): Connect returned -1, errno is 36 18:33:20 libtsocks(22539): Connection in progress 18:33:20 libtsocks(22539): Handle loop completed for socket 3 in state 1, returning 36 18:33:20 libtsocks(22539): Intercepted call to select with 4 fds, 0xbfff5760 0xbfff57e0 0xbfff5860, timeout bfff5758 18:33:20 libtsocks(22539): Checking requests for socks enabled socket 3 18:33:20 libtsocks(22539): Socket 3 was set for events 18:33:20 libtsocks(22539): Checking socket 3 for events 18:33:20 libtsocks(22539): Socket had write event 18:33:20 libtsocks(22539): Beginning handle loop for socket 3 18:33:20 libtsocks(22539): In request handle loop for socket 3, current state of request is 1 18:33:20 libtsocks(22539): Connecting to 10.220.1.19 port 1080 18:33:20 libtsocks(22539): Connect returned -1, errno is 56 18:33:20 libtsocks(22539): Error 56 attempting to connect to SOCKS server (Socket is already connected) 18:33:20 libtsocks(22539): Handle loop completed for socket 3 in state 14, returning 56 18:33:20 libtsocks(22539): Finished intercepting select(), 2 events 18:33:20 libtsocks(22539): Intercepted call to select with 6 fds, 0xbfffe410 0x00000000 0x00000000, timeout bfffe400 18:33:20 libtsocks(22539): Call to close(5) 18:33:20 libtsocks(22539): Intercepted call to select with 4 fds, 0xbfff5760 0xbfff57e0 0xbfff5860, timeout bfff5758 Dec 14 18:33:20.894 +0000 [WARN] Unexpected TLS error: wrong version number (or failed handshake). Closing connection to server at nowwhat.lateralis.org:48100 (fd 3) 18:33:20 libtsocks(22539): Intercepted call to select with 4 fds, 0xbfff5760 0xbfff57e0 0xbfff5860, timeout bfff5758 18:33:20 libtsocks(22539): Call to close(3) 18:33:20 libtsocks(22539): Call to close() received on file descriptor 3 which is a connection request of status 14 Dec 14 18:33:20.900 +0000 [INFO] Error while delivering packets; 1/1 left in queue Dec 14 18:33:20.902 +0000 [INFO] Error was: Error occurred while delivering packets to server at nowwhat.lateralis.org:48100 18:33:20 libtsocks(22539): Call to close(3) Dec 14 18:33:20.931 +0000 [INFO] No packets delivered % -- Darren Bane

[markd@…]

A revision has been committed. Please test it.

[markd@…]

Please reopen if you still experience the problem.