libsdl @1.2.15-20200718_0 fails to activate on High Sierra

[ryandesign (Ryan Carsten Schmidt)]

On the High Sierra buildbot worker only, libsdl @1.2.15-20200718_0 builds but ​fails to activate:

x ./opt/local/share/doc/libsdl/html/html/sdlunlockyuvoverlay.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlmutexv.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdloverlay.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/video.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlfreewav.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlgetappstate.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/guideeventexamples.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/guideinput.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdljoystickgetball.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/eventstructures.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlpauseaudio.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdljoyballevent.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlgetcursor.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlgetkeystate.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdljoystickindex.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlwmgetcaption.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlpixelformat.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlopenaudio.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlsurface.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlgeterror.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/guidebasicsinit.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdljoybuttonevent.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlgetkeyname.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlgetrgb.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlcondwait.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlquit.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/time.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlglsetattribute.html: Failed to restore metadata
x ./opt/local/share/doc/libsdl/html/html/sdlcdresume.html: Failed to restore metadata

bsdtar: Error exit delayed from previous errors.
Command failed: /usr/bin/bzip2 -d -c /opt/local/var/macports/software/libsdl/libsdl-1.2.15-20200718_0+x11.darwin_17.x86_64.tbz2 | ( bsdtar -xvp --hfsCompression -f - )
Exit code: 1
Error: Failed to activate libsdl: command execution failed

Thinking this was a fluke, I ​forced another build of libsdl which succeeded and distributed the previously built archive. But then I manually downloaded that archive and was unable to extract it on my own High Sierra system:

$ tar xjf ~/Downloads/libsdl-1.2.15-20200718_0+x11.darwin_17.x86_64.tbz2
tar: copyfile unpack (./opt/local/share/man/man3/SDL_CreateCursor.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_WM_SetCaption.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_JoystickNumBalls.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_UnlockAudio.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_Surface.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_RemoveTimer.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_Color.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_SaveBMP.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_ConvertAudio.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_Overlay.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_Flip.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_DestroySemaphore.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_CD.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_BuildAudioCVT.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_mutexV.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_JoystickOpened.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_CDStatus.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_DisplayFormatAlpha.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_GL_LoadLibrary.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_CDResume.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_CreateYUVOverlay.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_ThreadID.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_PixelFormat.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_DestroyCond.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_GetCursor.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_GetAudioStatus.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_PushEvent.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_CDPause.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/man/man3/SDL_GetGamma.3.gz) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlcdresume.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlglsetattribute.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/time.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlquit.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlcondwait.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlgetrgb.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlgetkeyname.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdljoybuttonevent.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/guidebasicsinit.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlgeterror.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlsurface.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlopenaudio.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlpixelformat.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlwmgetcaption.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdljoystickindex.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlgetkeystate.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlgetcursor.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdljoyballevent.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlpauseaudio.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/eventstructures.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdljoystickgetball.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/guideinput.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/guideeventexamples.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlgetappstate.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlfreewav.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/video.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdloverlay.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlmutexv.html) failed: File exists
tar: copyfile unpack (./opt/local/share/doc/libsdl/html/html/sdlunlockyuvoverlay.html) failed: File exists

I deleted the archive from the server, uninstalled the port on the buildbot worker, and triggered ​another build of libsdl which did the same thing again.

If I have MacPorts build libsdl from source on my own High Sierra system it builds fine. According to tar tf the two archives have contents with identical filenames, but each archive has them in a slightly different nonalphabetical order. Both systems are on APFS filesystems, and, unlike HFS, APFS doesn't sort items automatically.

When I manually extracted buildbot's libsdl archive on my system and it failed, I noticed that it had already extracted some ._ files.

I'm not sure why the problem happens on the 10.13 buildbot worker and not the 10.14 or 10.15 workers or my own 10.13 system, but I do suspect the ._ files of being relevant to the problem. The solution may be to add a post-extract block to remove the ._ files, or to repackage the tarball so that the files don't contain the extended attributes to begin with.

[jmroot (Joshua Root)]

Hm, is this another issue with hfscompression? I guess I'll clean up the source tarball in any case.

[ryandesign (Ryan Carsten Schmidt)]

I don't think so; I'm using hfscompression on my system too.

[jmroot (Joshua Root)]

In 2261af77ed3c1f8f11f3d3c3a0900da249113c13/macports-ports (master):

libsdl: remove stray xattrs from files

Rev bump because it installed but failed to activate on some systems.

Fixes: #61018