rsync @3.2.2: segfault during build, seems to be SIMD related

[herbygillot (Herby Gillot)]

macOS: 10.15.6 19G73 Xcode 11.6 11E708

Building rsync in a non-standard MacPorts prefix, compilation fails with a segmentation fault while compiling simd-checksum-x86_64.o:

E_CONFIG_H -Wall -W -I/opt/macports-test/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -c flist.c -o flist.o
clang: error: unable to execute command: Segmentation fault: 11
clang: error: clang frontend command failed due to signal (use -v to see invocation)
Apple clang version 11.0.0 (clang-1100.0.33.17)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
clang: note: diagnostic msg: PLEASE submit a bug report to http://developer.apple.com/bugreporter/ and include the crash backtrace, preprocessed source, and associated run script.
clang: note: diagnostic msg:
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /opt/macports-test/var/macports/build/_Users_herby_Source_macports-ports_net_rsync/rsync/work/.tmp/simd-checksum-x86_64-1b895c.cpp
clang: note: diagnostic msg: /opt/macports-test/var/macports/build/_Users_herby_Source_macports-ports_net_rsync/rsync/work/.tmp/simd-checksum-x86_64-1b895c.sh
clang: note: diagnostic msg: Crash backtrace is located in
clang: note: diagnostic msg: /opt/macports-test/var/macports/build/_Users_herby_Source_macports-ports_net_rsync/rsync/work/.home/Library/Logs/DiagnosticReports/clang_<YYYY-MM-DD-HHMMSS>_<hostname>.crash
clang: note: diagnostic msg: (choose the .crash file that corresponds to your crash)
clang: note: diagnostic msg:

********************
If you can't fix the issue, re-run ./configure with --disable-simd.
make: *** [simd-checksum-x86_64.o] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/opt/macports-test/var/macports/build/_Users_herby_Source_macports-ports_net_rsync/rsync/work/rsync-3.2.2'
Command failed:  cd "/opt/macports-test/var/macports/build/_Users_herby_Source_macports-ports_net_rsync/rsync/work/rsync-3.2.2" && /usr/bin/make -j16 -w all
Exit code: 2
Error: Failed to build rsync: command execution failed
DEBUG: Error code: CHILDSTATUS 64986 2
DEBUG: Backtrace: command execution failed
    while executing
"system {*}$notty {*}$callback {*}$nice $fullcmdstring"
    invoked from within
"command_exec -callback portprogress::target_progress_callback build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"
Error: See /opt/macports-test/var/macports/logs/_Users_herby_Source_macports-ports_net_rsync/rsync/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port rsync failed

After modifying the port build with SIMD disabled (added --disable-simd):

configure.args      --with-rsyncd-conf=${prefix}/etc/rsyncd.conf \
                    --disable-simd

...the port builds fine without issue.

[jmroot (Joshua Root)]

clang-1100.0.33.17 is from Xcode 11.3.1. Maybe you need to update your CLTs?

[herbygillot (Herby Gillot)]

That did the trick... removing /Library/Developer/CommandLineTools and reinstalling with xcode-select --install resolved the issue... maybe that should be added to New Ticket Guidelines under the compilation issues bullet point.

[jmroot (Joshua Root)]

You most likely suffered from ProblemHotlist#reinstall-clt (really would be nice if Apple fixed that).

[ryandesign (Ryan Carsten Schmidt)]

Reopening to set correct resolution.

Replying to jmroot:

You most likely suffered from ProblemHotlist#reinstall-clt (really would be nice if Apple fixed that).

That problem is only that the receipt gets deleted, so has nothing to do with this build failure.

[ryandesign (Ryan Carsten Schmidt)]

The closest resolution is "invalid", since although it is a bug, it is solved by updating the command line tools or Xcode.

Ideally I would modify the rsync port to warn the user to upgrade the CLT or Xcode if an older version is found, but MacPorts doesn't have a built-in way to do that. We have the xcodeversion portgroup for doing that just for Xcode versions, and we have the cltversion portgroup but I am unfamiliar with it. If someone else knows how to use the cltversion portgroup to do that for this port, feel free.