dosbox-x: fails 32bit build error: no matching function for call to 'CGGetDisplaysWithPoint'

[kencu (Ken)]

​https://build.macports.org/builders/ports-10.6_i386-builder/builds/17003/steps/install-port/logs/stdio

/opt/local/bin/clang++-mp-9.0 -DHAVE_CONFIG_H -I. -I../..  -I../../include -I../../src/aviwriter "-DRESDIR=\"\"" -I../../src -I../../src/mt32 -Wno-int-to-void-pointer-cast   -Wno-address-of-packed-member   -Wno-format-zero-length   -Wno-missing-field-initializers   -Wno-strict-aliasing   -Wno-implicit-fallthrough   -Wno-deprecated-declarations   -Wconversion-null   -Wsign-promo   -Wlogical-op   -pedantic   -Wunused   -Wextra   -Wall  -I/opt/local/include -I/opt/local/include/LegacySupport -I/usr/local/include -I/opt/local/include/SDL2 -D_THREAD_SAFE -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_emulators_dosbox-x/dosbox-x/work/dosbox-x-0.83.5/vs2015/sdlnet/linux-host/include -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_emulators_dosbox-x/dosbox-x/work/dosbox-x-0.83.5/vs2015/sdlnet/linux-host/include/SDL -I/opt/local/include/freetype2 -I/opt/local/include/libpng16   -pipe -Os -Wno-unknown-warning-option -stdlib=libc++ -arch i386 -std=gnu++11 -MT menu_osx.o -MD -MP -MF $depbase.Tpo -c -o menu_osx.o menu_osx.mm &&\
	mv -f $depbase.Tpo $depbase.Po
menu_osx.mm:531:15: error: no matching function for call to 'CGGetDisplaysWithPoint'
        err = CGGetDisplaysWithPoint(pt,1,&did,&cnt);
              ^~~~~~~~~~~~~~~~~~~~~~

I believe it needs an explicit NSPointToCGPoint conversion to make this work. Will try on a 32bit machine (or a universal build).

[kencu (Ken)]

and about 10,000 sinister looking warnings about overflows when building 32 bit as well .... this port may not build 32 built correctly.

[ryandesign (Ryan Carsten Schmidt)]

Replying to kencu:

I believe it needs an explicit NSPointToCGPoint conversion to make this work.

Probably. Software written in the 64-bit era gets very sloppy about the distinction between NSPoint and CGPoint because there is no distinction between them in 64-bit.

[kencu (Ken)]

should be fixed by [8850d27178d617bb67c9f22d53b84f461020bc31/macports-ports]. Will close if buildbots agree.