Changes between Initial Version and Version 1 of Ticket #61137


Ignore:
Timestamp:
Sep 7, 2020, 7:04:47 AM (4 years ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Replying to JDLH:

The libffi Portfile changed on Sept 4, 2020 with commit 81c3c7d "libffi: Fix universal variant". As far as I can tell, this did not changed the contents of ffi.h.

It should have changed the contents of /opt/local/include/ffi.h to just: 

#ifndef __LP64__
#include "i386-ffi.h"
#else
#include "x86_64-ffi.h"
#endif

The error you reported is the reason why I made that change now, and the reason why we had made the original equivalent change for previous libffi versions long ago (see #31459 and #25439), and it fixed the problem for me.

The error message, "unterminated conditional directive", is mentioned in several bug reports. Many of those reports point to ​https://github.com/Sarcasm/flycheck-irony/issues/20, where it is described as a bug in LLVM, fixed in January 2018. Maybe that fix does not propagate back to macOS 10.13 High Sierra?

No idea. There could be any number of reasons why the muniversal portgroup merger is unable to merge a file successfully. I haven't attempted to analyze why it is unable to merge ffi.h or whether the problem is the one described in the link you mentioned.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #61137 – Description

    initial v1  
    1616`/opt/local/include/ffi.h is provided by: libffi` (per `port provides`).
    1717
    18 The **glib2** Portfile changed on Sep 5, 2020 with [https://github.com/macports/macports-ports/commit/bd5d6800828a3dcda1b65f3999fa748a365b168e commit bd5d680 "ports that link with libffi: rebuild with libffi 3.3"]. It looks like just the revision number incremented, to force a rebuild.
     18The **glib2** Portfile changed on Sep 5, 2020 with [changeset:bd5d6800828a3dcda1b65f3999fa748a365b168e/macports-ports commit bd5d680 "ports that link with libffi: rebuild with libffi 3.3"]. It looks like just the revision number incremented, to force a rebuild.
    1919
    20 The **libffi** Portfile changed on Sept 4, 2020 with [https://github.com/macports/macports-ports/commit/81c3c7d5008897d976d4a46a59da0d34fc8a8492 commit 81c3c7d "libffi: Fix universal variant"]. As far as I can tell, 
     20The **libffi** Portfile changed on Sept 4, 2020 with [changeset:81c3c7d5008897d976d4a46a59da0d34fc8a8492/macports-ports commit 81c3c7d "libffi: Fix universal variant"]. As far as I can tell, 
    2121this did not changed the contents of `ffi.h`.
    2222