molden: error: implicit declaration of function

[p-walt]

Hi there, I have tried multiple times to install molden using MacPorts. I have tried multiple versions of gcc and still get the same errors generated.

[p-walt]

Log file of the failed building of the molden port

[ryandesign (Ryan Carsten Schmidt)]

Looks like there are many errors in the log of this form:

src/xwin.c:8709:4: error: implicit declaration of function 'plinz_' [-Werror,-Wimplicit-function-declaration]
   plinz_(isel,istat,
   ^

Implicit function declaration errors are a new problem we're having to contend with since the introduction of Xcode 12. Prior to that, this was only considered a warning. We should fix these problems, but until we do, you can avoid them by downgrading to Xcode 11 and/or the Xcode 11 version of the command line tools.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #61985.

It is too difficult for me to fix errors in molden (the file that these errors occur in is over 92,000 lines long) so I will report it to the developer of molden for them to fix.

[ryandesign (Ryan Carsten Schmidt)]

I did report the problems to the developer. They did not respond to my email but did add -Wno-implicit-function-declaration to the build system, which I promptly removed because that is not the correct fix (it is not going to work on Apple Silicon systems). However since it has now been awhile and the developer has not fixed it the correct way, I will allow -Wno-implicit-function-declaration back into the build system and will instead mark the port as incompatible with Apple Silicon.

[ryandesign (Ryan Carsten Schmidt)]

In 2ddc57db263fc9a0be09ea1888a4893d4f6e6435/macports-ports (master):

molden: Allow build with Xcode 12 on x86_64

Closes: #61231

[ryandesign (Ryan Carsten Schmidt)]

Correction: the developer did respond and I had not replied to reiterate the unsuitability of -Wno-implicit-function-declaration. I've now done that.

[valerie-vallet]

Despite your fix, there are still compiling issues. See the attached log file

[valerie-vallet]

compilation log file

[ryandesign (Ryan Carsten Schmidt)]

The developer removed -Wno-implicit-function-declaration again, perhaps because of my email letting them know it was not a suitable fix, but has not implemented any other fix, so the problems will continue until the developer fixes the problem. If the problem affects you, you could email the developer and let them know.

[ryandesign (Ryan Carsten Schmidt)]

I had not updated molden to a new version in a year because no new version appeared to be available. This turns out to have been because the homepage and download location changed. I'm now updating molden to the latest version (7.1) which still hasn't fixed the implicit function declaration problems. I'm therefore re-adding -Wno-implicit-function-declaration and marking the port as unsuitable for use with the arm64 architecture. Users who try to install the port on Apple Silicon machines will get the x86_64 version running in emulation (assuming MacPorts is able to install all of its dependencies with the +universal variant first). Users who wish to have an Apple Silicon-native version should contact the developer and ask them to fix the implicit function declarations.

[ryandesign (Ryan Carsten Schmidt)]

In 067f7f34a8a540aea559615220a163934f62a997/macports-ports (master):

molden: Update to 7.1

Update to 7.1. Update homepage and master_sites and fix livecheck.

Remove stealth update provisions; let's see if the developers have
learned to refrain from doing stealth updates by now.

Use -fallow-argument-mismatch to allow building with gcc10 and later.

Use -Wno-implicit-function-declaration to allow building with Xcode 12
and later on x86_64, therefore mark the port as incompatible with arm64.

Closes: #61231