Opened 4 years ago

Closed 4 years ago

#61242 closed defect (fixed)

f2c: fix compilation

Reported by: DanielO (Daniel O'Connor) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: f2c

Description

f2c is ancient and terrible C code, so just disable all warnings while building it.

Attachments (1)

fixf2c.diff (1.4 KB) - added by DanielO (Daniel O'Connor) 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by DanielO (Daniel O'Connor)

Attachment: fixf2c.diff added

comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

In 6750c33a865e87466825d63c0c24f1efce234ca2/macports-ports (master):

f2c: Build only f2c

Don't build xsum, which only gets run during the build to verify the
checksums of the source code files. MacPorts checksums already do that.

See: #61242

comment:2 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

In 5f54c8059f6cb3d0c7ad7120ae1a27198f8ba922/macports-ports (master):

f2c: Fix implicit declaration of function

See: #61242

comment:3 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Owner: set to ryandesign
Status: newaccepted

You didn't mention what compilation problem these changes fix, but I assume it is the "implicit declaration of function" problem we've seen in many other ports with Xcode 12 and later. Rather than disabling all warnings, I fixed that one problem. Is that sufficient to close this ticket?

comment:4 Changed 4 years ago by DanielO (Daniel O'Connor)

Yes, I actually thought there were other errors also but perhaps those were just warnings. Basically I saw a lot of compiler complaints and decided the big hammer would be fine.

If fixing that one error makes it build then I think that is satisfactory - thanks.

comment:5 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: acceptedclosed

It builds for me on Catalina with Xcode 12 so I'll close it. If it doesn't build for you please re-open and attach a log showing the error message.

Note: See TracTickets for help on using tickets.