thrift +glib2 error: implicit declaration of function 'thrift_protocol_decorator_write_message_begin' is invalid in C99

[ve3m]

Trying to build thrift with glib2 variant without success.

Os Catalina 10.15.7

[ve3m]

building log

[ve3m]

thrift without any variants works fine

[mf2k (Frank Schima)]

The Milestone field is for use by Macports team members only, please do not set it.

[mf2k (Frank Schima)]

Error appears to be:

/bin/sh ../../libtool  --tag=CC   --mode=compile /usr/bin/clang -DHAVE_CONFIG_H   -Isrc -I src/thrift/c_glib -I/opt/local/include -DBOOST_TEST_DYN_LINK -isysroot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -Wall -Wextra -pedantic -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include  -I../../lib/c_glib/src/thrift -pipe -Os -isysroot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -arch x86_64 -MT src/thrift/c_glib/protocol/libthrift_c_glib_la-thrift_binary_protocol_factory.lo -MD -MP -MF src/thrift/c_glib/protocol/.deps/libthrift_c_glib_la-thrift_binary_protocol_factory.Tpo -c -o src/thrift/c_glib/protocol/libthrift_c_glib_la-thrift_binary_protocol_factory.lo `test -f 'src/thrift/c_glib/protocol/thrift_binary_protocol_factory.c' || echo './'`src/thrift/c_glib/protocol/thrift_binary_protocol_factory.c
src/thrift/c_glib/protocol/thrift_multiplexed_protocol.c:60:9: error: implicit declaration of function 'thrift_protocol_decorator_write_message_begin' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
ret = thrift_protocol_decorator_write_message_begin(protocol, service_name, message_type, seqid, error);
        ^

[ryandesign (Ryan Carsten Schmidt)]

Implicit function declaration errors are new in Xcode 12. If you want to avoid this problem while we figure out how to fix it, downgrade to Xcode 11 and/or the Xcode 11 version of the command line tools.

[chrstphrchvz (Christopher Chavez)]

Does the change in this PR help? ​https://github.com/macports/macports-ports/pull/8584

[chrstphrchvz (Christopher Chavez)]

In 30a666954615f874f594b01c0eb4f48c3e6755f9/macports-ports (master):

thrift: actually use patchfiles

Fixes: #61252

[chrstphrchvz (Christopher Chavez)]

For some reason [b2bd4b8f0d/macports-ports] did not close this ticket; that is the commit which added (but did not completely use) the patches to fix this issue.

[michaelld (Michael Dickens)]

Actually ... it did close this ticket. Alls well that ends well!

[ve3m]

Replying to michaelld:

Actually ... it did close this ticket. Alls well that ends well!

Just installed. It works.

Thank you.